Fix type mismatch in eigenvalue case determination and add tests#454
Open
shantanusharma wants to merge 1 commit intoTorchSim:mainfrom
Open
Fix type mismatch in eigenvalue case determination and add tests#454shantanusharma wants to merge 1 commit intoTorchSim:mainfrom
shantanusharma wants to merge 1 commit intoTorchSim:mainfrom
Conversation
Author
ac394b2 to
3ed040b
Compare
Member
|
Thank you for the PR! I think that the issue you are addressing here might be deleted in the larger changes in #439. In that PR in How did you come across this issue? was it exposed by a simulation error, human code analysis or agentic code analysis? |
Author
|
Gotcha @CompRhys. Yes. h/t Augment Code agentic code analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a type mismatch bug in eigenvalue merging