Upgrade ECharts from v5.5 to v6.1#1288
Conversation
| minimumReleaseAge: 12960 | ||
| minimumReleaseAgeExclude: | ||
| - wasm-pack | ||
| - echarts |
There was a problem hiding this comment.
Like wasm-pack above, this addition is temporary and we should remember to remove it later.
|
@kasbah, given the suspicious hacks that Claude invented to make the dependency on a Git repo work (see commit below) and how tiny the dependency ToposInstitute/echarts-solid@7191b18 (This does work for me locally, even if the CI is currently failing.) |
|
I pushed a commit that switches to my fork (I don't have write permissions on Topos' fork) where I built the package and committed the I guess including the package into our monorepo would be a little cleaner but a bit more work, plus a little more annoying to switch back if the previous maintainer does decide to maintain echarts-solid again (though that doesn't seem that likely given the lack of commits for 2 years). Let me know how you want to proceed. |
|
Thanks! Your proposed solution (committing the We should use the fork in the Topos org though. I've given you permissions on that repo. Would be great if you could push your changes to that repo and then update this PR accordingly. |
|
Done |
Co-authored-by: Kaspar Bumke <git@kaspar.systems>
ECharts v6 has been out for nearly a year. The recent release of v6.1.0 was a good reminder that we should upgrade.
However,
echarts-solidappears to be unmaintained (see alxnddr/echarts-solid#2), so I've switched the dependency to our fork.