Skip to content

Upgrade ECharts from v5.5 to v6.1#1288

Merged
epatters merged 2 commits into
mainfrom
echarts-v6
May 22, 2026
Merged

Upgrade ECharts from v5.5 to v6.1#1288
epatters merged 2 commits into
mainfrom
echarts-v6

Conversation

@epatters

@epatters epatters commented May 20, 2026

Copy link
Copy Markdown
Member

ECharts v6 has been out for nearly a year. The recent release of v6.1.0 was a good reminder that we should upgrade.

However, echarts-solid appears to be unmaintained (see alxnddr/echarts-solid#2), so I've switched the dependency to our fork.

@epatters epatters requested a review from kasbah May 20, 2026 20:21
@epatters epatters added visualization Visualization and plotting build CI/CD, linting, deployments, and anything Nix labels May 20, 2026
Comment thread pnpm-workspace.yaml
minimumReleaseAge: 12960
minimumReleaseAgeExclude:
- wasm-pack
- echarts

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like wasm-pack above, this addition is temporary and we should remember to remove it later.

Comment thread pnpm-workspace.yaml Outdated
@epatters

epatters commented May 20, 2026

Copy link
Copy Markdown
Member Author

@kasbah, given the suspicious hacks that Claude invented to make the dependency on a Git repo work (see commit below) and how tiny the dependency echarts-solid actually is, we might be better off just copying it directly into our monorepo. I'd appreciate your help finding a clean way to proceed.

ToposInstitute/echarts-solid@7191b18

(This does work for me locally, even if the CI is currently failing.)

@kasbah kasbah requested a review from jmoggr as a code owner May 21, 2026 10:18
@kasbah kasbah marked this pull request as draft May 21, 2026 10:19
@kasbah

kasbah commented May 21, 2026

Copy link
Copy Markdown
Member

I pushed a commit that switches to my fork (I don't have write permissions on Topos' fork) where I built the package and committed the dist/ folder. That seems to work without extra hacks so that's an option.

I guess including the package into our monorepo would be a little cleaner but a bit more work, plus a little more annoying to switch back if the previous maintainer does decide to maintain echarts-solid again (though that doesn't seem that likely given the lack of commits for 2 years).

Let me know how you want to proceed.

@epatters

epatters commented May 21, 2026

Copy link
Copy Markdown
Member Author

Thanks! Your proposed solution (committing the dist folder) seems best. Let's go with that.

We should use the fork in the Topos org though. I've given you permissions on that repo. Would be great if you could push your changes to that repo and then update this PR accordingly.

@kasbah

kasbah commented May 22, 2026

Copy link
Copy Markdown
Member

Done

@epatters epatters merged commit ba5f661 into main May 22, 2026
17 checks passed
@epatters epatters deleted the echarts-v6 branch May 22, 2026 18:05
quffaro pushed a commit that referenced this pull request Jun 15, 2026
Co-authored-by: Kaspar Bumke <git@kaspar.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build CI/CD, linting, deployments, and anything Nix visualization Visualization and plotting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants