fixx: add common cause mapping layer#242
Open
Faith-okereke wants to merge 2 commits into
Open
Conversation
Contributor
|
@Faith-okereke your PR does not have a close tag for the issue number you resolved. This is your task #280, add #280 to your PR description |
codeZe-us
reviewed
Jun 19, 2026
codeZe-us
left a comment
codeZe-us
left a comment
Contributor
There was a problem hiding this comment.
@Faith-okereke This PR updates the rendering logic, schema definitions, and report generation for common causes, but it completely misses adding the actual common_causes fields to the error mapping entries in the TOML files, so update the TOML files in crates/core/src/taxonomy/data/ to include one to three plain-English cause strings per Tier 1 error code to ensure they actually surface in the decoded output
Author
|
Hi, I have updated the files to include the strings as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
Common causes were already present in embedded TOML entries.
This change ensures they load reliably, are shown in human CLI output, and are covered by tests.
Verified with cargo test -p prism-core tier1.
Verified the new Tier 1 taxonomy/common-cause tests with cargo test -p prism-core tier1. Full cargo test -p prism-core currently fails in unrelated RPC client tests.