Repository navigation
CI runner: drop the case-insensitive dpkg workaround - #67
Open
chandarith-chea wants to merge 2 commits into
Open
chandarith-chea wants to merge 2 commits into
chandarith-chea wants to merge 2 commits into
Conversation
Dockiva 0.6.8 keeps container files in a case-sensitive store, so linux-libc-dev's xt_CONNMARK.h and xt_connmark.h unpack side by side.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The runner image skipped the uppercase netfilter headers (
xt_[A-Z]*,ipt_[A-Z]*,ip6t_[A-Z]*) because Dockiva 0.6.7 and older kept container files on case-insensitive APFS, wherelinux-libc-dev'sxt_CONNMARK.handxt_connmark.hcollided and dpkg failed. v0.6.8 ships the case-sensitive engine store (engine Tomnerb/dockiva-engine#7), so the workaround can go.Change
scripts/ci-runner/Dockerfileno longer writes/etc/dpkg/dpkg.cfg.d/dockiva-case-insensitive. Nothing else changes.Checked
On Dockiva 0.6.8,
docker --context dockiva build --no-cache scripts/ci-runnersucceeds. In the image,/usr/include/linux/netfilter/xt_CONNMARK.handxt_connmark.hboth exist, andlinux-libc-devisinstall ok installed.Note
A runner host still on Dockiva 0.6.7 or older can't build this image. Update the host first.