You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Settings files now skip malformed entries and unknown keys while applying valid settings.
Numeric settings remain within their supported ranges, and FPS values are limited to 20, 30, or 60. Boolean values are interpreted consistently: zero is off, and any nonzero value is on.
Saving settings preserves the established key order and uses the existing safe file-writing process.
No actionable comments were generated in the recent review.
Walkthrough
Settings parsing and serialization are exposed as public functions, and file loading and saving use them. The pull request also adds unit tests for settings handling and snow behavior.
Changes: Settings parsing and serialization
Layer / File(s)
Summary
Settings parsing, serialization, and validation src/config.rs
apply_settings parses settings text, and format_settings serializes the settings snapshot. load delegates parsing, and save uses the formatter. Tests cover defaults, validation, malformed input, and round trips.
Snow behavior tests
Layer / File(s)
Summary
Snow behavior checks src/snow.rs
Added tests for bucket indexing, floor-like classification, construction, height relaxation, and smoothstep values.
This change moves settings parsing and formatting into separate functions and adds unit tests for settings and snow behavior. Production behavior should be unchanged, and no merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title "Add config and snow unit tests" matches the changeset. The PR adds unit tests in src/config.rs (defaults, clamping, FPS validation, boolean parsing, malformed input, round-tripping) and in …
Full details: Title check
Explanation
The title "Add config and snow unit tests" matches the changeset. The PR adds unit tests in src/config.rs (defaults, clamping, FPS validation, boolean parsing, malformed input, round-tripping) and in src/snow.rs (bucket-index bounds, owner classification, Snow::new, height relaxation, smoothstep). It also exposes apply_settings and format_settings, which the title does not mention, but the tests are the main change. The title is concise and specific.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 7875c1d and 0f3cd15.
Files selected for processing: 2
src/config.rs
src/snow.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit