Skip to content

Add config and snow unit tests - #9

Merged
Tomjerri1 merged 3 commits into
mainfrom
add-tests
Nov 12, 2026
Merged

Tomjerri1 merged 3 commits into
mainfrom
add-tests

Conversation

@Tomjerri1

@Tomjerri1 Tomjerri1 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Settings files now skip malformed entries and unknown keys while applying valid settings.
    • Numeric settings remain within their supported ranges, and FPS values are limited to 20, 30, or 60. Boolean values are interpreted consistently: zero is off, and any nonzero value is on.
    • Saving settings preserves the established key order and uses the existing safe file-writing process.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Settings parsing and serialization are exposed as public functions, and file loading and saving use them. The pull request also adds unit tests for settings handling and snow behavior.

Changes: Settings parsing and serialization

Layer / File(s) Summary
Settings parsing, serialization, and validation
src/config.rs
apply_settings parses settings text, and format_settings serializes the settings snapshot. load delegates parsing, and save uses the formatter. Tests cover defaults, validation, malformed input, and round trips.

Snow behavior tests

Layer / File(s) Summary
Snow behavior checks
src/snow.rs
Added tests for bucket indexing, floor-like classification, construction, height relaxation, and smoothstep values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 0f3cd

This change moves settings parsing and formatting into separate functions and adds unit tests for settings and snow behavior. Production behavior should be unchanged, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title "Add config and snow unit tests" matches the changeset. The PR adds unit tests in src/config.rs (defaults, clamping, FPS validation, boolean parsing, malformed input, round-tripping) and in …
Full details: Title check

Explanation

The title "Add config and snow unit tests" matches the changeset. The PR adds unit tests in src/config.rs (defaults, clamping, FPS validation, boolean parsing, malformed input, round-tripping) and in src/snow.rs (bucket-index bounds, owner classification, Snow::new, height relaxation, smoothstep). It also exposes apply_settings and format_settings, which the title does not mention, but the tests are the main change. The title is concise and specific.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7875c1d and 0f3cd15.

Files selected for processing: 2

  • src/config.rs
  • src/snow.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@Tomjerri1 Tomjerri1 changed the title Add tests Add config and snow unit tests Nov 12, 2026
@Tomjerri1
Tomjerri1 merged commit 44a9432 into main Nov 12, 2026
3 checks passed
@Tomjerri1
Tomjerri1 deleted the add-tests branch November 12, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant