Skip to content

Hide console window in release builds - #12

Merged
Tomjerri1 merged 2 commits into
mainfrom
hide-console
Nov 13, 2026
Merged

Tomjerri1 merged 2 commits into
mainfrom
hide-console

Conversation

@Tomjerri1

@Tomjerri1 Tomjerri1 commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Improvements
    • On Windows, non-debug builds now open without displaying an extra console window. Debug builds are unchanged. This provides a cleaner launch experience for end users while preserving the existing console behavior during development.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The crate now applies a Windows subsystem attribute to non-debug builds. Debug builds do not receive the attribute.

Changes: Windows subsystem configuration

Layer / File(s) Summary
Apply subsystem attribute
src/main.rs
Adds a crate-level Windows subsystem attribute for non-debug builds.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to cec04

Release builds on Windows now run without a console window, as intended. The only side effect is that the optional --perf and --brushlog diagnostic output is not visible when launched from Explorer or a shortcut, which is a minor developer convenience matter.

Security architecture risk: Minimal · up to cec04

The change suppresses the automatic console window in non-debug Windows builds without changing application permissions, inputs, or state handling. No material security risk was identified in the reviewed change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The changed behavior applies to Windows application binaries built without debug assertions. The attribute does not itself expand process privileges, tenant reach, or access to protected resources.

Trust Boundaries and Controls

  • observed — The exact source delta contains no changes to input processing, authentication, authorization, credentials, or shared-state operations; it only adds the conditional executable subsystem attribute.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the console window is hidden in release builds. The raw summary confirms that src/main.rs adds a crate-level Windows subsystem attribute that applies to non-debug buil…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the console window is hidden in release builds. The raw summary confirms that src/main.rs adds a crate-level Windows subsystem attribute that applies to non-debug builds, which hides the console. The title is concise, specific, and matches the commit intent.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1f1f9c9 and cec047c.

Files selected for processing: 1

  • src/main.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

@Tomjerri1
Tomjerri1 merged commit 361089a into main Nov 13, 2026
2 checks passed
@Tomjerri1
Tomjerri1 deleted the hide-console branch November 13, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant