Add Vertex AI support for Google and Anthropic models#3
Merged
Tom-Ryder merged 1 commit intoTom-Ryder:mainfrom Mar 26, 2026
Merged
Add Vertex AI support for Google and Anthropic models#3Tom-Ryder merged 1 commit intoTom-Ryder:mainfrom
Tom-Ryder merged 1 commit intoTom-Ryder:mainfrom
Conversation
Contributor
Author
|
I added a second commit to this PR that applies |
subpop
force-pushed
the
add-vertex
branch
3 times, most recently
from
9867fa6 to
1d43164
Compare
Contributor
Author
|
The linter introduced a bunch of errors unrelated to these provider types. I'm happy to rebase this PR once those are fixed, but I'm going to leave the fixing of them to another PR. There's already rider commits in this PR that shouldn't really be here (applying swift formatting). |
Owner
|
Main is cleaned up, the formatting and lint issues were on my end. If you rebase onto main, things should be much smoother now. I also touched some of the Gemini client code so you'll want to check that lines up. |
Building on the GeminiClient, add support for models hosted through GCP Vertex, both Google models and Anthropic models.
Contributor
Author
|
Yey! Tests and linting issues are all cleaned up. |
Owner
|
Looks great, thanks! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on the GeminiClient, add support for models hosted through GCP Vertex, both Google models and Anthropic models.