Skip to content

Remove chat activity shimmer bars #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Afnanksalal merged 1 commit into from
Jun 26, 2026
Merged

Remove chat activity shimmer bars #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ All live in `tokito_ui::components` (aliased `c` above). Each takes
| `inspector_row` | `inspector_row(ui, t, label, value)` | Label-on-left, value-on-right key/value row for inspector / property panels. |
| `list_section_label` | `list_section_label(ui, t, label, count)` | "Symbols (24)" style group label for dense side-panel lists. |
| `empty_state` | `empty_state(ui, t, message)` | Centred "nothing here" placeholder card. |
| `chat_activity` | `chat_activity(ui, t, id_source, label, detail)` | Assistant loading/activity bubble with subtle dots and a shimmer rail for slow background work. |
| `chat_activity` | `chat_activity(ui, t, id_source, label, detail)` | Assistant loading/activity bubble with subtle dots and status copy for slow background work. |

### Icons

Expand Down
67 changes: 3 additions & 64 deletions src/components.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1938,9 +1938,9 @@ pub fn chat_bubble(
/// Assistant activity bubble for slow background work.
///
/// This is the "premium but quiet" loading state for chat: normal assistant
/// bubble chrome, a compact status row, three breathing dots, and two
/// skeleton-style shimmer lines. It deliberately avoids backend/provider
/// wording; the host supplies product-facing `label` and `detail` copy.
/// bubble chrome, a compact status row, three breathing dots, and product-
/// facing detail copy. It deliberately avoids backend/provider wording; the
/// host supplies the `label` and `detail` copy.
///
/// `id_source` scopes child ids so multiple activity bubbles can coexist
/// without reflow making their animation state fight.
Expand All @@ -1959,8 +1959,6 @@ pub fn chat_activity(ui: &mut Ui, t: &Tokens, id_source: impl Hash, label: &str,
vec2(content_width, 0.0),
Layout::top_down(Align::Min).with_cross_justify(true),
|ui| {
let phase = (time * 0.48).fract();

ui.horizontal(|ui| {
badge(ui, t, label);
ui.add_space(t.space_1);
Expand All @@ -1974,11 +1972,6 @@ pub fn chat_activity(ui: &mut Ui, t: &Tokens, id_source: impl Hash, label: &str,
.wrap(),
);
}

ui.add_space(t.space_3);
activity_rail(ui, t, phase, 0.92);
ui.add_space(t.space_1);
activity_rail(ui, t, (phase + 0.34).fract(), 0.64);
},
);
});
Expand All @@ -1998,60 +1991,6 @@ fn activity_dots(ui: &mut Ui, t: &Tokens, time: f32) -> Response {
response
}

fn activity_rail(ui: &mut Ui, t: &Tokens, phase: f32, width_factor: f32) -> Response {
let width = (ui.available_width() * width_factor.clamp(0.2, 1.0)).max(0.0);
let (rect, response) = ui.allocate_exact_size(vec2(width, 4.0), Sense::hover());
let rounding = egui::Rounding::same(2.0);
let painter = ui.painter();
painter.rect_filled(rect, rounding, t.border_soft.gamma_multiply(0.82));

if rect.width() <= 1.0 {
return response;
}

let span = (rect.width() * 0.36).clamp(24.0, 120.0);
let lead = rect.left() - span + (rect.width() + span) * phase;
let core = Rect::from_min_size(pos2(lead, rect.top()), vec2(span, rect.height()));
let before = Rect::from_min_size(
pos2(lead - span * 0.45, rect.top()),
vec2(span * 0.5, rect.height()),
);
let after = Rect::from_min_size(
pos2(lead + span * 0.82, rect.top()),
vec2(span * 0.42, rect.height()),
);

paint_clipped_rect(
painter,
before,
rect,
rounding,
t.accent_2.gamma_multiply(0.18),
);
paint_clipped_rect(painter, core, rect, rounding, t.accent.gamma_multiply(0.62));
paint_clipped_rect(
painter,
after,
rect,
rounding,
t.accent.gamma_multiply(0.24),
);
response
}

fn paint_clipped_rect(
painter: &egui::Painter,
rect: Rect,
clip: Rect,
rounding: egui::Rounding,
fill: Color32,
) {
let clipped = rect.intersect(clip);
if clipped.width() > 0.0 && clipped.height() > 0.0 {
painter.rect_filled(clipped, rounding, fill);
}
}

/// State for [`chat_composer`].
#[derive(Clone, Debug, Default)]
pub struct ChatComposerState {
Expand Down
Loading