Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions .github/workflows/mirror-oss.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,22 @@ jobs:
--endpoint "${OSS_ENDPOINT}" \
--output-format json > bucket-versioning.json
python - <<'PY'
from scripts.ossutil_json import load_ossutil_json
import json
import re
from pathlib import Path

def load_ossutil_json(path: str) -> object:
raw = Path(path).read_text(encoding="utf-8")
document = raw.lstrip("\ufeff \t\r\n")
if not document.startswith(("{", "[")):
raise ValueError(
"ossutil output does not start with a JSON object or array"
)
value, end = json.JSONDecoder().raw_decode(document)
trailing = document[end:].strip()
if trailing and not re.fullmatch(r"\d+(?:\.\d+)?\(s\) elapsed", trailing):
raise ValueError("unexpected output after ossutil JSON document")
return value

value = load_ossutil_json("bucket-versioning.json")

Expand Down Expand Up @@ -186,9 +201,23 @@ jobs:
--endpoint "${OSS_ENDPOINT}" \
--output-format json > "${metadata}"
METADATA_PATH="${metadata}" python - <<'PY'
import json
import os
import re
from scripts.ossutil_json import load_ossutil_json
from pathlib import Path

def load_ossutil_json(path: str) -> object:
raw = Path(path).read_text(encoding="utf-8")
document = raw.lstrip("\ufeff \t\r\n")
if not document.startswith(("{", "[")):
raise ValueError(
"ossutil output does not start with a JSON object or array"
)
value, end = json.JSONDecoder().raw_decode(document)
trailing = document[end:].strip()
if trailing and not re.fullmatch(r"\d+(?:\.\d+)?\(s\) elapsed", trailing):
raise ValueError("unexpected output after ossutil JSON document")
return value

value = load_ossutil_json(os.environ["METADATA_PATH"])

Expand Down
3 changes: 2 additions & 1 deletion tests/test_workflow_contract.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ def test_oss_workflow_has_no_moving_alias_and_uses_reviewed_shared_bucket() -> N
assert "oss-version-ids.json" in workflow
assert 'active != {"enabled"}' in workflow
assert "load_ossutil_json" in workflow
assert "scripts.ossutil_json" in workflow
assert workflow.count("JSONDecoder().raw_decode") == 2
assert workflow.count("unexpected output after ossutil JSON document") == 2


def test_all_external_actions_are_pinned_to_full_commit_sha() -> None:
Expand Down
Loading