Recover concrete action promises without tool calls (#989) - #1182
Open
lihongguang-0014 wants to merge 1 commit into
Open
Recover concrete action promises without tool calls (#989)#1182lihongguang-0014 wants to merge 1 commit into
lihongguang-0014 wants to merge 1 commit into
Conversation
lihongguang-0014
marked this pull request as ready for review
August 13, 2026 09:06
Open-Squilla
marked this pull request as draft
August 13, 2026 11:36
Open-Squilla
marked this pull request as ready for review
August 15, 2026 13:49
Open-Squilla
marked this pull request as draft
August 15, 2026 17:38
lihongguang-0014
force-pushed
the
codex/fix-989-action-completion
branch
from
September 7, 2026 09:17
d1c29eb to
f1c0051
Compare
lihongguang-0014
marked this pull request as ready for review
September 7, 2026 09:18
lihongguang-0014
force-pushed
the
codex/fix-989-action-completion
branch
from
September 7, 2026 09:24
f1c0051 to
858ae62
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 7, 2026
lihongguang-0014
force-pushed
the
codex/fix-989-action-completion
branch
from
September 7, 2026 13:41
858ae62 to
853529e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix #989 by reusing the existing bounded text-only recovery loop when a tool-capable model explicitly promises a concrete next action but emits no tool call.
warn_modelrecovery mode by default while preserving the explicitoffcompatibility setting.This rebuild removes the previous action-completion protocol,
complete_action_tasktool, shell grammar, global tool side-effect inventory, new terminal type, persistence changes, channel changes, and Web changes. Recovery remains limited to two model nudges and never replays a tool call.Compatibility and Upgrade
No wire, database, persisted-session, Web, desktop, or tool contract changes are required. Existing configurations that set
text_only_tool_recovery_mode=offretain the old stop-on-text behavior. The detector intentionally covers concrete English and Chinese action promises rather than claiming a universal task-completion proof.The synthetic upgrade rehearsal test allows 30 seconds on Windows and 15 seconds elsewhere. This only accounts for hosted Windows process startup variance; updater runtime behavior is unchanged.
Branch
Base branch: main
Target exception: N/A
Issue
Linked issue: Fixes #989
Release Note
Release note: Tool-capable turns recover when the model promises a concrete next action without making the tool call.
Tests
git diff --checkpassed.No live provider or browser run was performed.
Maintainer Live Check
Maintainer live check: no
Surface: engine
Safety
No secrets, local paths, private prompts/transcripts, channel identifiers, or private fixtures are included.
Third-Party Origin
Third-party origin: none
Details if non-none: N/A.
Documentation Changes