Skip to content

Add flyio review app ci cd#612

Open
DevinCLane wants to merge 2 commits intomainfrom
add-flyio-ci-cd
Open

Add flyio review app ci cd#612
DevinCLane wants to merge 2 commits intomainfrom
add-flyio-ci-cd

Conversation

@DevinCLane
Copy link
Copy Markdown
Collaborator

@DevinCLane DevinCLane commented Aug 4, 2025

Description

Adds CI/CD to create ephemeral apps for reviewing upon each PR

@eric will need to add these in the GitHub Secrets section

FLY_API_TOKEN - Fly.io API token
MONGODB_ATLAS_PUBLIC_API_KEY - MongoDB Atlas public API key
MONGODB_ATLAS_PRIVATE_API_KEY - Your MongoDB Atlas private API key
MONGODB_USERNAME - Username for MongoDB Atlas cluster
MONGODB_PASSWORD - Password for MongoDB Atlas cluster

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and npm run test:e2e and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@DevinCLane
Copy link
Copy Markdown
Collaborator Author

this has some git issues 😆

@emmebravo
Copy link
Copy Markdown
Collaborator

this has some git issues 😆

It says the name needs to be lowercase letters only

@DevinCLane
Copy link
Copy Markdown
Collaborator Author

this has some git issues 😆

It says the name needs to be lowercase letters only

the name of what now?

@DevinCLane
Copy link
Copy Markdown
Collaborator Author

I think i fixed the git issues

@emmebravo
Copy link
Copy Markdown
Collaborator

this has some git issues 😆

It says the name needs to be lowercase letters only

the name of what now?

If you open the failed deployment logs, you'll see "Error: app name must consist of only lowercase letters, numbers, and dashes." The name of the app in fly-review.yml is violating this requirement. Change it to deploy-review-app see if that fixes the deployment issue.

@DevinCLane
Copy link
Copy Markdown
Collaborator Author

DevinCLane commented Aug 5, 2025

@intelagense when you get a chance can you generate a new Fly token with fly tokens org <ORG NAME>, that will allow this to work

then follow these docs for the mongodb secrets we need: https://github.com/mongodb/atlas-github-action?tab=readme-ov-file#complete-the-prerequisites

mongo atlas command: atlas organizations apiKeys create --desc "together pr review app" --role "ORG_OWNER"

in the github secrets under SECRETS AND VARIABLES -> actions add:

  • FLY_API_ORG_TOKEN
  • MONGODB_ATLAS_PRIVATE_API_KEY
  • MONGODB_ATLAS_PUBLIC_API_KEY

@merrua
Copy link
Copy Markdown
Collaborator

merrua commented Aug 12, 2025

Error: required flag(s) "orgId" not set
It probably should be the github together organization

@DevinCLane
Copy link
Copy Markdown
Collaborator Author

Error: required flag(s) "orgId" not set It probably should be the github together organization

yeah i'm still having trouble with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git Branch Preview Environments via GitHub Actions on PRs

3 participants