Skip to content

Move PR template to .github and add issue keyword to auto-close issue…#606

Closed
absar22 wants to merge 3 commits intoTogether-100Devs:mainfrom
absar22:update-pr-template
Closed

Move PR template to .github and add issue keyword to auto-close issue…#606
absar22 wants to merge 3 commits intoTogether-100Devs:mainfrom
absar22:update-pr-template

Conversation

@absar22
Copy link
Copy Markdown
Contributor

@absar22 absar22 commented Jul 30, 2025

Description

Moved the pull request template file from docs/pull_request_template.md to .github/pull_request_template.md.
Additionally, updated the template content to include a proper issue reference using the Resolves #[issue] keyword, which enables automatic issue closing by GitHub when the PR is merged.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and npm run test:e2e and all tests have passed successfully or I have included details within my PR on the failure
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@absar22
Copy link
Copy Markdown
Contributor Author

absar22 commented Jul 30, 2025

"Hi! PR is ready for review 😊. It moves the PR template to .github and adds auto-closing issue keyword. Let me know if anything needs changes!"

@@ -0,0 +1,30 @@

# Description
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reads like the description of your PR. instead we want none of these comments and to leave the description that was in place in the prior PR template


# Checklist:

- [x] This PR is up to date with the main branch, and merge conflicts have been resolved
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of these checklists should be filled out, as others will fill them out when they submit their PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it — updating the checklist now. 👍

@DevinCLane
Copy link
Copy Markdown
Collaborator

duplicated by #609

@DevinCLane DevinCLane closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add issue keyword to pull request template, and move PR template under github folder

2 participants