Skip to content

check room management Frontend#2

Open
Tisarji wants to merge 4 commits intodevelopfrom
main
Open

check room management Frontend#2
Tisarji wants to merge 4 commits intodevelopfrom
main

Conversation

@Tisarji
Copy link
Copy Markdown
Owner

@Tisarji Tisarji commented May 8, 2025

This pull request introduces several updates to the reserve-book-repair project, focusing on dependency updates, color standardization, and UI/UX improvements. Key changes include adding new dependencies, replacing hardcoded class-based color styles with inline styles for consistency, and enhancing the RoomManagementClient component for better usability and maintainability.

Dependency Updates:

  • Added chalk (v5.4.1) and figlet (v1.8.1) as new dependencies in package.json and package-lock.json. Updated the chalk package from v4.1.2 to v5.4.1, including changes to its dependency and engine requirements. ([[1]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-340905b26d0eccc7c34f8d0dfea53748bd6425d6b911bcee77f295aff173b212R23-R27), [[2]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-9c7bb77e5a7665ebe242df172220fd346cae75cd58fc3f999a2ee68c7cacbd16R22-R26), [[3]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-9c7bb77e5a7665ebe242df172220fd346cae75cd58fc3f999a2ee68c7cacbd16L3589-R3604), [[4]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-9c7bb77e5a7665ebe242df172220fd346cae75cd58fc3f999a2ee68c7cacbd16R4667-R4683), [[5]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-9c7bb77e5a7665ebe242df172220fd346cae75cd58fc3f999a2ee68c7cacbd16R4826-R4837))
  • Added @types/figlet (v1.7.0) as a new development dependency. ([[1]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-340905b26d0eccc7c34f8d0dfea53748bd6425d6b911bcee77f295aff173b212R40), [[2]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-9c7bb77e5a7665ebe242df172220fd346cae75cd58fc3f999a2ee68c7cacbd16R39), [[3]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-9c7bb77e5a7665ebe242df172220fd346cae75cd58fc3f999a2ee68c7cacbd16R2652-R2658))

Color Standardization:

  • Replaced hardcoded Tailwind CSS color classes (e.g., text-blue-600, bg-blue-600) with inline styles using the hex color #2a80fe for consistency across components. This applies to icons, buttons, and other elements in buildinggrid/page.tsx and roomgrid/page.tsx. ([[1]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-edeb796f8e4a87673588035f7737b58282f43f123a80aca0204a1e445cc2f7f4L42-R42), [[2]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-edeb796f8e4a87673588035f7737b58282f43f123a80aca0204a1e445cc2f7f4L61-R61), [[3]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-edeb796f8e4a87673588035f7737b58282f43f123a80aca0204a1e445cc2f7f4L71-R95), [[4]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-6c894d7fa5730600371cf55c97cd71a49ad5e9720f9ea3a14370777374a749edL112-R120), [[5]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-6c894d7fa5730600371cf55c97cd71a49ad5e9720f9ea3a14370777374a749edL185-R194), [[6]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-6c894d7fa5730600371cf55c97cd71a49ad5e9720f9ea3a14370777374a749edL221-R221), [[7]](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-6c894d7fa5730600371cf55c97cd71a49ad5e9720f9ea3a14370777374a749edL238-R238))

UI/UX Enhancements:

  • Refactored the RoomManagementClient component:
    • Replaced FontAwesome icons with lucide-react icons for a more modern look. ([reserve-book-repair/src/app/(management)/room/RoomManagementClient.tsxL2-R24](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-c4669f4210113b20f29f8ff635d67f5367a2620d686c93641b9215143a0bd365L2-R24))
    • Simplified the Room type and removed unused state management (mode state). ([reserve-book-repair/src/app/(management)/room/RoomManagementClient.tsxL2-R24](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-c4669f4210113b20f29f8ff635d67f5367a2620d686c93641b9215143a0bd365L2-R24))
    • Redesigned the search input and table layout for better responsiveness and accessibility. Added a "no data" state with an actionable reset button. ([reserve-book-repair/src/app/(management)/room/RoomManagementClient.tsxL43-R146](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-c4669f4210113b20f29f8ff635d67f5367a2620d686c93641b9215143a0bd365L43-R146))
    • Replaced column definitions with explicit JSX for better readability and maintainability. ([reserve-book-repair/src/app/(management)/room/RoomManagementClient.tsxL43-R146](https://github.com/Tisarji/Reserve-Project/pull/2/files#diff-c4669f4210113b20f29f8ff635d67f5367a2620d686c93641b9215143a0bd365L43-R146))

Summary by Sourcery

Refactor room and user management components with improved UI/UX, icon updates, and color standardization across the application

New Features:

  • Added management actions for rooms and users with edit and delete functionality

Enhancements:

  • Replaced FontAwesome icons with Lucide React icons
  • Improved search functionality with clear button
  • Added 'no data' state for empty tables
  • Standardized color scheme using hex color #2a80fe

Documentation:

  • Updated component type definitions

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented May 8, 2025

Reviewer's Guide

The PR updates dependencies (chalk, figlet) via package.json modifications and standardizes UI colors by replacing Tailwind classes with inline styles (using #2a80fe) in homepage grid components. Key frontend components, RoomManagementClient.tsx and UserManagementClient.tsx, were refactored for improved UI/UX by migrating to lucide-react icons, redesigning table and search elements with direct JSX rendering, and enhancing data display states; RoomManagementClient.tsx also saw simplification of its Room type and state. Additionally, tsconfig.json was updated to include start-dev.js.

File-Level Changes

Change Details Files
Introduced new project dependencies and updated an existing one.
  • Added chalk (v5.4.1) and figlet (v1.8.1) as dependencies.
  • Added @types/figlet (v1.7.0) as a development dependency.
  • Updated chalk package from v4.1.2 to v5.4.1.
reserve-book-repair/package.json
reserve-book-repair/package-lock.json
Standardized UI element colors by replacing CSS classes with inline styles.
  • Replaced Tailwind CSS color utility classes with inline style attributes.
  • Applied the hex color #2a80fe consistently for primary branding elements.
reserve-book-repair/src/app/(homepage)/buildinggrid/page.tsx
reserve-book-repair/src/app/(homepage)/roomgrid/page.tsx
Modernized and improved the room management interface.
  • Migrated icons from FontAwesome to lucide-react for a consistent icon set.
  • Simplified Room data type and removed unused mode state management.
  • Rebuilt table structure using direct JSX instead of a column configuration array.
  • Enhanced search functionality and added a clear "no data" state with a reset option.
reserve-book-repair/src/app/(management)/room/RoomManagementClient.tsx
Upgraded the user management interface for better usability and consistency.
  • Replaced FontAwesome icons with lucide-react icons.
  • Improved search input and redesigned table using direct JSX for column rendering.
  • Added inline action buttons (Edit, Delete) for each user row.
  • Implemented a "no data" state with a clear search option.
reserve-book-repair/src/app/(management)/user/UserManagementClient.tsx
Modified the TypeScript compiler's file inclusion criteria.
  • Added start-dev.js to the include array.
reserve-book-repair/tsconfig.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant