补全剩余未翻译文本#134
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request localizes hard-coded strings within the Mindustry client by adding new keys to the Chinese and English resource bundles and updating the Java source code via a patch. The review feedback identifies a UI consistency issue in the bullet.pierce-detail strings for both languages, where an unnecessary color reset tag ([]) causes the following text to lose its intended status color. No other issues were found.
| bullet.pierce-falloff = {0}%衰减 | ||
| bullet.pierce-count-infinite = 无限 | ||
| bullet.pierce-count-multiplier = {0}x | ||
| bullet.pierce-detail = [stat]{0}[]穿透[lightgray]{1}[]{2} |
There was a problem hiding this comment.
在 bullet.pierce-detail 中，{0} 后的 [] 会重置颜色，导致后面的“穿透”文本变为默认颜色（白色）。在原代码中，这部分文本是继承自前面的 [stat] 颜色的（通常为黄色）。建议移除这个 [] 以保持 UI 颜色的一致性。
bullet.pierce-detail = [stat]{0}穿透[lightgray]{1}[]{2}
| bullet.pierce-falloff = {0}% falloff | ||
| bullet.pierce-count-infinite = infinite | ||
| bullet.pierce-count-multiplier = {0}x | ||
| bullet.pierce-detail = [stat]{0}[] pierces [lightgray]{1}[]{2} |
There was a problem hiding this comment.
在 bullet.pierce-detail 中，{0} 后的 [] 会重置颜色，导致后面的 “pierces” 文本变为默认颜色（白色）。在原代码中，这部分文本是继承自前面的 [stat] 颜色的（通常为黄色）。建议移除这个 [] 以保持 UI 颜色的一致性。
bullet.pierce-detail = [stat]{0} pierces [lightgray]{1}[]{2}
DeterMination-Wind
force-pushed
the
fix/localize-remaining-hardcoded-texts
branch
from
3e41fdc to
1d8b4d2
Compare
|
/gemini review 一下有没有非本PR预期的行为变化 |
There was a problem hiding this comment.
Code Review
This pull request focuses on internationalization and localization, moving hardcoded strings into property bundles and updating patches to use the Core.bundle system across various UI components, statistics, and game messages. Feedback points out several missing localization keys in the bundle files for bullet and lightning properties. Additionally, a potential UI bug was identified in the WaveInfoDialog where the removal of a capacity check could result in invalid slider ranges for units without item storage.
| + suffix = Core.bundle.format("bullet.pierce-falloff", Strings.autoFixed(rail.pierceDamageFactor * 100f, 1)); | ||
| + }else{ | ||
| + str.append(type.pierceCap == -1 ? "无限" : type.pierceCap + "x"); | ||
| + suffix = type.pierceCap == -1 ? Core.bundle.get("bullet.pierce-count-infinite") : Core.bundle.format("bullet.pierce-count-multiplier", type.pierceCap); |
There was a problem hiding this comment.
键值 bullet.pierce-count-infinite 在资源文件 (bundle-mdtx.properties 和 bundle-mdtx_en.properties) 中均未定义。请在资源文件中补充该键值（例如：bullet.pierce-count-infinite = 无限），或者修改代码使用已有的键值。
| + String shotsText = shots > 0 ? Core.bundle.format("bullet.lightning-shots", shots) : ""; | ||
| + if(lengthRand > 0){ | ||
| + str += String.format("[stat]%d~%d[]长度", length, length + lengthRand); | ||
| + sep(table, Core.bundle.format("bullet.lightning.detail", shotsText, Strings.autoFixed(damage, 1), Core.bundle.format("bullet.lightning.length-range", length, length + lengthRand))); | ||
| + }else{ | ||
| + str += String.format("[stat]%d[]长度", length); | ||
| + sep(table, Core.bundle.format("bullet.lightning.detail", shotsText, Strings.autoFixed(damage, 1), Core.bundle.format("bullet.lightning.length", length))); | ||
| + } |
There was a problem hiding this comment.
键值 bullet.lightning-shots 和 bullet.lightning.detail 在资源文件中未定义。根据资源文件中的内容，建议分别使用 bullet.lightning.count 和 bullet.lightning.summary。
String shotsText = shots > 0 ? Core.bundle.format("bullet.lightning.count", shots) : "";
if(lengthRand > 0){
sep(table, Core.bundle.format("bullet.lightning.summary", shotsText, Strings.autoFixed(damage, 1), Core.bundle.format("bullet.lightning.length-range", length, length + lengthRand)));
}else{
sep(table, Core.bundle.format("bullet.lightning.summary", shotsText, Strings.autoFixed(damage, 1), Core.bundle.format("bullet.lightning.length", length)));
}
| + dialog.show(); | ||
| + }); | ||
| + if(group.items != null && group.type.itemCapacity > 0){ | ||
| + if(group.items != null){ |
There was a problem hiding this comment.
此处移除了 group.type.itemCapacity > 0 的判断。如果单位的物品容量为 0，下方的 a.slider(1, group.type.itemCapacity, 1, ...) 将会创建一个范围为 [1, 0] 的无效滑块，这可能会导致 UI 渲染错误或异常。建议保留容量检查。
if(group.items != null && group.type.itemCapacity > 0){
|
/gemini 有没有非本PR预期的行为变化 |
|
你好！我已经对本次 PR 进行了详细检查。本次 PR 的主要目的是补全研究与属性界面中剩余的未翻译文本，并补充了相应的中英文文案。经过对代码的审查，这些更改仅涉及资源包（ |
|
/gemini 有没有其他非本PR预期的的代码改动 |
|
你好！我已再次对本次 PR 的代码进行了全面审查。本次 PR 的改动主要集中在资源包（ |
| invincible = new StatusEffect("invincible"){{ | ||
| healthMultiplier = Float.POSITIVE_INFINITY; | ||
| show = false; | ||
| + color = Color.red; |
| short width = stream.readShort(), height = stream.readShort(); | ||
|
|
||
| - if(limitSchematicSize && (width > 128 || height > 128)) throw new IOException("Invalid schematic: Too large (max possible size is 128x128)"); | ||
| + if(limitSchematicSize && (width > 1024 || height > 1024)) throw new IOException("Invalid schematic: Too large (max possible size is 128x128)"); |
2 participants
补全研究与属性界面中剩余未翻译文本，补充中英文文案。
已完成基础检查。