Skip to content

fix(tinyoffice): connect SSE directly to API, bypass Next.js rewrite #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crisdias wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tinyoffice): connect SSE directly to API, bypass Next.js rewrite #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tinyoffice/src/lib/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,12 @@ export function subscribeToEvents(
onError?: (err: Event) => void,
eventTypes?: string[]
): () => void {
const es = new EventSource(`${API_BASE}/api/events/stream`);
// Connect directly to the API server for SSE, bypassing the Next.js rewrite
// proxy which buffers responses and breaks real-time event streaming.
const sseBase = typeof window !== "undefined"
? (process.env.NEXT_PUBLIC_SSE_URL ?? `${window.location.protocol}//${window.location.hostname}:3777`)
: "";
Comment on lines +383 to +385
Copy link
Copy Markdown

@greptile-apps greptile-apps bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback URL ignores NEXT_PUBLIC_API_URL

The fallback constructs the SSE URL from window.location.hostname hardcoded to port 3777. However, API_BASE at the top of the file already respects NEXT_PUBLIC_API_URL, which users may have configured to point to an API server on a different hostname (e.g., http://my-api-server:3777). In that case, the new fallback will silently connect SSE to the wrong host (${window.location.hostname}:3777), breaking SSE for any deployment where the API is not co-located with the frontend server — even though all other API calls route correctly via API_BASE.

Using NEXT_PUBLIC_API_URL in the fallback chain (before the window.location guess) would preserve consistency and avoid surprises:

Suggested change
const sseBase = typeof window !== "undefined"
? (process.env.NEXT_PUBLIC_SSE_URL ?? `${window.location.protocol}//${window.location.hostname}:3777`)
: "";
const sseBase = typeof window !== "undefined"
? (process.env.NEXT_PUBLIC_SSE_URL ?? process.env.NEXT_PUBLIC_API_URL ?? `${window.location.protocol}//${window.location.hostname}:3777`)
: "";

This way:

  1. NEXT_PUBLIC_SSE_URL – explicit SSE override (current behaviour)
  2. NEXT_PUBLIC_API_URL – reuse the already-configured API host (fixes the regression)
  3. window.location.hostname:3777 – last-resort guess for plain local-dev setups

const es = new EventSource(`${sseBase}/api/events/stream`);

const handler = (e: MessageEvent) => {
try { onEvent(JSON.parse(e.data)); } catch { /* ignore parse errors */ }
Expand Down