Repository navigation
Translate the sign-in and account pages into every language the device speaks - #28
Open
Ptitlouis6012 wants to merge 1 commit into
Open
Ptitlouis6012 wants to merge 1 commit into
Ptitlouis6012 wants to merge 1 commit into
Conversation
…e speaks The pages the QR code opens on a phone - the TigerTag sign-in, the Google pairing wait, the account page and the short replies - read their words from a table of four columns (PT, EN, ES, FR). German, Italian, Polish, Chinese and, with the previous commit, Russian and Dutch all fell back to English. The table gains six columns, DE, IT, PL, ZH, RU and NL, for all fifty rows, translated from the English; wl() maps each language to its column. Rows that are pasted into a JavaScript string carry no straight apostrophe. check-i18n.py already reads the column count from the declaration, so it checks the new width on its own; only its wording and the one doc that quoted "four languages" change.
Ptitlouis6012
force-pushed
the
feat/web-pages-six-languages
branch
from
October 15, 2026 05:17
480eee4 to
4b89d3a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The pages the QR code opens on a phone — the TigerTag sign-in, the Google pairing wait, the account page and the short replies — read their words from a table in
webcfg.cppthat has four columns (PT, EN, ES, FR). German, Italian, Polish and Chinese fall back to English there today, and so would Russian and Dutch once #26 is in.wl()maps each language to its column; the two Portuguese still share the first.check-i18n.pyreads the column count from the declaration, so it checks the new width as is; only its wording and one doc that quoted "four languages" change.Why: someone who picked their language on the device should not meet an English page on the phone half way through signing in.
Builds on #26
This needs
LANG_RUandLANG_NL, which #26 adds, so the branch starts from #26's branch: its first commit is #26's, and the one to review here is the last (Translate the sign-in and account pages...). Once #26 is merged the diff here shrinks to that one commit.I checked that the two do not conflict, in either merge order: this commit applied to
mainalone against #26, and #26 squashed ontomainand then this branch. They only sharewebcfg.cpp, in different places (LANG_CODESthere, the table andwl()here). If #26 changes before it is merged, I will rebase this one on top.What you tested it on
Built with
pio run -e tigerspool;bash scripts/verify.sh --quickpasses except "generated files match their generator", which also fails on a cleanmainon the machine used.check-i18n.pyreports both tables clean (fifty rows, ten columns each, in the enum's order), and I printed a sample of rows per column to check each holds the right language.Not tested: the pages in a browser on a device. The strings are static data and the portal page was already checked on a device in #26, but nobody has opened the sign-in page in these languages.
Checklist
CHANGELOG.mdupdated for anything user-visible. (left to the release ritual)