ff-697 — Silenced expected httpx.RemoteProtocolError in feeds loader - #526
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new, explicit classification for an expected httpx.RemoteProtocolError case (“illegal header line”) so the feeds loader can treat it as a known network failure and track it via FeedError.
Changes:
- Added detection/logging for “illegal header line” protocol errors in the loader.
- Introduced a new
FeedError.network_illegal_header_lineenum value. - Documented the change in the unreleased changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ffun/ffun/loader/operations.py | Adds message matching + error code mapping for “illegal header line”. |
| ffun/ffun/feeds/entities.py | Extends FeedError with a new network error code. |
| changes/unreleased.md | Adds an unreleased entry describing ff-697. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
83
to
88
| if "illegal header line" in message: | ||
| log.warning("network_illegal_header_line") | ||
| error_code = FeedError.network_illegal_header_line | ||
| elif "Server disconnected without sending a response" in message: | ||
| log.warning("network_disconection_without_response") | ||
| error_code = FeedError.network_disconection_without_response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.