Add tests for mutate - #117
Open
mistermichaelll wants to merge 17 commits into
Open
mistermichaelll wants to merge 17 commits into
mistermichaelll wants to merge 17 commits into
Conversation
This isn't one-to-one with dplyr because of how dataframes works under the hood
this example clarifies that progressive transformations require separate calls to mutate
This reverts commit b0e7acd.
Member
|
Will take a look this weekend. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing my adventure of adding unit tests for some of the core
Tidierfunctionality–this PR adds some tests related to@mutate.As noted in #115 ,
@mutatedoesn't work progressively (eg. you can't reuse a created variable in the same call). Since this is expected behavior and just a difference between R and Julia, I went ahead and added a docstring example explaining that you can't do this and to use separate calls to@mutateinstead.There's an outstanding question (#116) about whether
@mutateshould allow dropping columns by passingnothing. If the answer is "no" there, then I'll just remove that test as well.The rest of the tests pass and verify some of the core
@mutatefunctionality and expected behavior. 🎉