Skip to content

Block editorial pagination during refresh - #430

Merged
NomadDigita merged 1 commit into
mainfrom
fix/pr429-block-pagination-during-refresh
Oct 28, 2026
Merged

NomadDigita merged 1 commit into
mainfrom
fix/pr429-block-pagination-during-refresh

Conversation

@NomadDigita

@NomadDigita NomadDigita commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Disable loading older notices and articles while a save and list refresh is in progress.
  • Prevents a newly started page request from using the old offset while the refreshed first page replaces the list.

Review follow-up

Addresses the final pagination race noted on PR #429 after it merged.

Verification

GitHub Actions checks will run on this PR.

Summary by CodeRabbit

  • Bug Fixes
    • Maintenance-notice and article pagination buttons are disabled while saving or while a pagination request is loading, preventing overlapping actions.

@vercel

vercel Bot commented Oct 28, 2026

Copy link
Copy Markdown

Deployment failed for project tidelight with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/tessera8?upgradeToPro=build-rate-limit

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T06:29:34.264251Z 7a6f4c0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3dec5846-abbf-4d6e-8d96-66ab33d58e9d
Commits

Reviewing files that changed from the base of the PR and between a6bcfb0 and 7a6f4c0.

Files selected for processing: 1
  • app/operator/communications/editor.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The maintenance and article pagination buttons are now disabled while a save is in progress. Their existing loading conditions and labels remain unchanged.

Changes: Pagination controls

Layer / File(s) Summary
Disable pagination during saves
app/operator/communications/editor.tsx
Both pagination buttons are disabled while a save is in progress, as well as while pagination is loading.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 7a6f4

The pagination controls are gated during saves while existing loading behavior remains unchanged.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: disabling editorial pagination during list refreshes.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@NomadDigita
NomadDigita merged commit 9bc2105 into main Oct 28, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant