Skip to content

feat: transport bounded Gemini array-root schemas (#596) - #597

Merged
sjungwon03 merged 1 commit into
mainfrom
feat/596-gemini-array-root
Oct 31, 2026
Merged

sjungwon03 merged 1 commit into
mainfrom
feat/596-gemini-array-root

Conversation

@sjungwon03

Copy link
Copy Markdown
Member

Scope

Closes #596. Refs #116 and existing plan552 native schema mapping gap.
Plan: docs/plans/596-gemini-array-root.md (written before tests/code).

Minimal native root guard extension: explicit strict:false literal array roots alongside object roots. Immutable schema transport, same recursive keywords/local refs/depth/visit limits. Scalar/nullable/untyped roots, strict/tool/Anthropic remain unsupported before secrets. No output validation or live-provider guarantee. No pins/dependencies/storage/#561 edits.

TDD and verification

  • Meaningful red:105pass/5expectedfail before source edit. Minimal guard made new cases pass; superseded historical array-root rejection expectations updated with retained malformed negatives.
  • Final format111pass; focused format/native-stream/AI SDK structured244pass. Actual OpenAI SDK sockets on both bases and native stream deliver array text. IAM/Deny/limits/audit/usage/persistence/privacy and malformed/depth/ref/strict/tool negatives covered.
  • Standard FULL npm run check FAILED:8198pass/10fileSIGKILL/1optionalexternalPGskip (~210s,2CPU/2GiB). No reported assertion failures. NOT a local full pass; no retry/concurrency/deadline/assertion weakening. Failed files:model-descriptive-metadata;postgres-dual-http-server;postgres-gateway-runtime;postgres-http-server;postgres-model-catalog;postgres-policy-simulator;postgres-sso-management-http;postgres-usage-reader;proxy-token-lifetime-caps;sso-token-management.
  • Typecheck/lint passed(existing42warnings66infos); docs/contracts/links/fixture-secret and all6offline integrity checks passed; diffcheck passed. Only docs evidence additions followed full gate; final docscan passed.
  • No local Docker/bridge/systemd/live-provider certification; full feat: complete OpenRouter external-client compatibility #116 and unresolved feat: add Jev-assisted managed routing #7 stay open.

Exact-head formal independent GitHub approval AND all CI success required before normal merge. Read-only findings are not an approval.

Assisted-by: Codex

Refs: #596
Assisted-by: Codex
Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@github-actions github-actions Bot added ai-review-requested Review requested from sjungwon03-ai type:feature Product capability labels Oct 31, 2026

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Verdict: Approved

  • Reviewed: Literal array-root support, unchanged recursive schema/reference limits, immutable native transport, credential-access boundaries, regression tests, and documentation; no blocking issues found.
  • Checks: All seven reported CI checks passed on 487612315c57237a3f703f28deb4594658a1ab5f; independently ran 224 focused tests, typecheck, lint, documentation/fixture scanning, and pinned-schema checks successfully.

The reported full local run with ten file-level SIGKILL failures is not a full pass. This approval covers bounded schema transport, not generated-output validation or live-provider certification.

@sjungwon03
sjungwon03 merged commit fafba28 into main Oct 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-requested Review requested from sjungwon03-ai type:feature Product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: transport bounded Gemini array-root response schemas

2 participants