Repository navigation
feat: transport bounded Gemini array-root schemas (#596) - #597
Merged
Merged
Conversation
Refs: #596 Assisted-by: Codex Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03-ai
approved these changes
Oct 31, 2026
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: Literal array-root support, unchanged recursive schema/reference limits, immutable native transport, credential-access boundaries, regression tests, and documentation; no blocking issues found.
- Checks: All seven reported CI checks passed on
487612315c57237a3f703f28deb4594658a1ab5f; independently ran 224 focused tests, typecheck, lint, documentation/fixture scanning, and pinned-schema checks successfully.
The reported full local run with ten file-level SIGKILL failures is not a full pass. This approval covers bounded schema transport, not generated-output validation or live-provider certification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Closes #596. Refs #116 and existing plan552 native schema mapping gap.
Plan: docs/plans/596-gemini-array-root.md (written before tests/code).
Minimal native root guard extension: explicit strict:false literal array roots alongside object roots. Immutable schema transport, same recursive keywords/local refs/depth/visit limits. Scalar/nullable/untyped roots, strict/tool/Anthropic remain unsupported before secrets. No output validation or live-provider guarantee. No pins/dependencies/storage/#561 edits.
TDD and verification
Exact-head formal independent GitHub approval AND all CI success required before normal merge. Read-only findings are not an approval.
Assisted-by: Codex