Skip to content

feat: transport bounded Gemini oneOf schemas - #593

Merged
sjungwon03 merged 1 commit into
mainfrom
feat/592-gemini-oneof
Oct 31, 2026
Merged

sjungwon03 merged 1 commit into
mainfrom
feat/592-gemini-oneof

Conversation

@sjungwon03

Copy link
Copy Markdown
Member

Closes #592. Refs #116 and native schema mapping gap in plan552.

Scope

  • Transport nested oneOf lists of 1..16 recursively supported schemas unchanged under strict:false explicit object-root Gemini responseJsonSchema.
  • Official GenerationConfig explicitly interprets oneOf as anyOf: documented native limitation, NOT exclusive-union enforcement, generated-output validation or JSON Schema equivalence. Same-node anyOf plus oneOf remains locally rejected.
  • Shared depth/capture limits, immutable nonstream/native text-stream snapshots, SDK sockets, IAM/limits/audit/usage/persistence/privacy retained. References/tools/Anthropic/strict remain unsupported. No dependency/pin/storage/gateway: preserve observed timeout statuses #561 changes. Full feat: complete OpenRouter external-client compatibility #116 and unresolved feat: add Jev-assisted managed routing #7 remain open.

Verification

  • TDD red 93 passed /5 expected failures before production change; green98; final focused220 PASS.
  • Standard local full npm run check FAILED:8218 passed,10 file-level SIGKILL failures,1 optional external PostgreSQL skip (~220s,2GiB cgroup,two CPU affinity). No assertion failures reported; NOT a local full pass. No retry/concurrency/deadline weakening. Details and failed files in English plan592.
  • Typecheck/lint, planning/links/contracts/fixture-secret scan, all6 offline pins and diff whitespace PASS.
  • Initial plan file-tool write landed outside shell checkout; actual checkout plan copy followed red/green. Issue scope and external plan text preceded tests; chronology disclosed in plan.
  • No local Docker/bridge/systemd/live provider certification. Exact-head full CI plus independent formal APPROVED required before merge.

@github-actions github-actions Bot added ai-review-requested Review requested from sjungwon03-ai type:feature Product capability labels Oct 31, 2026

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Verdict: Approved

  • Reviewed: Complete diff, recursive oneOf branch and depth limits, same-node union rejection, immutable nonstream/native-stream transport, SDK sockets, and credential, IAM, accounting, and privacy boundaries.
  • Checks: All seven current-HEAD checks passed, including the full CI npm run check; independently ran 220 focused tests, typecheck, lint, documentation/contract checks, and all six pinned schema integrity checks successfully.

The documented Gemini limitation is accurate: oneOf is interpreted as anyOf, not exclusive matching or generated-output validation. The reported local full-suite SIGKILL failures are not counted as passes; live-provider certification remains outside this review.

@sjungwon03
sjungwon03 merged commit 78c0180 into main Oct 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-requested Review requested from sjungwon03-ai type:feature Product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: transport bounded Gemini oneOf schemas

2 participants