Repository navigation
feat: transport bounded Gemini oneOf schemas - #593
Merged
Merged
Conversation
sjungwon03-ai
approved these changes
Oct 31, 2026
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: Complete diff, recursive
oneOfbranch and depth limits, same-node union rejection, immutable nonstream/native-stream transport, SDK sockets, and credential, IAM, accounting, and privacy boundaries. - Checks: All seven current-HEAD checks passed, including the full CI
npm run check; independently ran 220 focused tests, typecheck, lint, documentation/contract checks, and all six pinned schema integrity checks successfully.
The documented Gemini limitation is accurate: oneOf is interpreted as anyOf, not exclusive matching or generated-output validation. The reported local full-suite SIGKILL failures are not counted as passes; live-provider certification remains outside this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #592. Refs #116 and native schema mapping gap in plan552.
Scope
Verification