Performance optimizations: O(1) lookups, single JSON load, parallel fetches by Copilot · Pull Request #29 · TheYoBots/libot-lb

Copilot · 2025-11-27T17:42:25Z

Identified and fixed several performance bottlenecks across Python and JavaScript code.

`bot_leaderboard.py`

Eliminate redundant file I/O: JSON file was read 26 times (once per type × 2 modes). Now loaded once in main() and passed to all get_bot_leaderboard() calls.
Move invariants outside loops: datetime.now(), timedelta(days=7), and variant type check now computed once per function call instead of per-bot.
Optimize get_available_bots(): Use set comprehension with single sort on write instead of list operations with repeated membership checks.

# Before: O(n) membership check on list, 26 JSON reads
if d['id'] not in available_bots:  # list
type in ['bullet', 'blitz', 'rapid', 'classical']  # per iteration

# After: O(1) set lookup, 1 JSON read passed to all calls
if bot_id not in available_bots:  # set
is_standard_variant = type in STANDARD_VARIANTS  # frozenset, computed once

`app.py`

Change TYPES from list to frozenset for O(1) route validation

`md2html.py`

Pre-compile regex patterns at module level
Replace chained if/elif with dictionary lookup for filename mapping

`js/bot-rank.js`

Parallel fetching: Replace sequential for loop with await to Promise.all() for 13 leaderboard files
Hoist constants and helper functions outside doSearch() to avoid recreation per call

// Before: sequential fetches (~13 round trips in series)
for (var t = 0; t < TYPES.length; t++) {
    var res = await fetch('/bot_leaderboard/' + type + '.md');
}

// After: parallel fetches (~1 round trip time)
Promise.all(TYPES.map(type => fetchRankForType(type, usernameLower)))

Original prompt

Identify and suggest improvements to slow or inefficient code

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…tions, and add parallel fetching Co-authored-by: TheYoBots <73843275+TheYoBots@users.noreply.github.com>

Co-authored-by: TheYoBots <73843275+TheYoBots@users.noreply.github.com>

TheYoBots

Also please update this Pr to the latest revision please

TheYoBots · 2026-01-11T15:13:15Z

    'threeCheck'
 ]

+# Use frozenset for O(1) membership checks in get_bot_leaderboard


Please remove this comment

TheYoBots · 2026-01-11T15:13:54Z

+                    print(f"Adding {bot_id} to available bots list")
    except Exception as e:
        print(e)
+    # Sort only once when writing to file


Remove this comment as well

TheYoBots · 2026-01-11T15:14:38Z

-    file_path = os.path.join(os.path.dirname(__file__), 'bot_leaderboard.json')
-    with open(file_path, 'r') as f:
-        bot_ratings = json.load(f)
+    # Reuse bot_ratings if passed to avoid redundant file reads


remove this comment as well

TheYoBots · 2026-01-11T15:17:40Z

        get_available_bots()
        get_all_bot_ratings()
+
+        # Load bot ratings once and reuse for all leaderboard generation


remove this comment

TheYoBots · 2026-01-11T15:19:32Z

-                    row.appendChild(tdVariant);
-                    row.appendChild(tdRank);
-                    tbody.appendChild(row);
+            // Fetch all leaderboard files in parallel using Promise.all


remove this comment

TheYoBots · 2026-01-11T15:19:52Z

 </footer>
 """

+# Dictionary for filename display name mapping - O(1) lookup instead of multiple conditionals


remove this comment

TheYoBots · 2026-01-11T15:21:22Z

+    "racingKings.md": "racing kings.md"
+}
+
+# Pre-compile regex patterns for better performance


remove this comment

TheYoBots · 2026-01-11T15:23:39Z

-                else:
-                    f = "racing kings.md"
-                h1_tag = generate_h1_tag(f)
+                # Use dictionary lookup with default fallback


remove this comment

Initial plan

acd9519

Copilot AI assigned Copilot and TheYoBots Nov 27, 2025

Copilot started work on behalf of TheYoBots November 27, 2025 17:42 View session

Copilot AI and others added 2 commits November 27, 2025 17:48

Improve performance: optimize data structures, reduce redundant opera…

7ace440

…tions, and add parallel fetching Co-authored-by: TheYoBots <73843275+TheYoBots@users.noreply.github.com>

Address code review: remove unnecessary fallback in DISPLAY lookup

82cd5f8

Co-authored-by: TheYoBots <73843275+TheYoBots@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Identify and suggest improvements to inefficient code~~ Performance optimizations: O(1) lookups, single JSON load, parallel fetches Nov 27, 2025

Copilot AI requested a review from TheYoBots November 27, 2025 17:54

Copilot finished work on behalf of TheYoBots November 27, 2025 17:54

TheYoBots requested changes Jan 11, 2026

View reviewed changes

Navigation Menu

Performance optimizations: O(1) lookups, single JSON load, parallel fetches - #29

Performance optimizations: O(1) lookups, single JSON load, parallel fetches#29
TheYoBots with Copilot wants to merge 3 commits into
masterfrom
copilot/improve-code-efficiency

Copilot AI commented Nov 27, 2025 •

edited

Loading

Uh oh!

TheYoBots left a comment

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

TheYoBots Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bot_leaderboard.py

app.py

md2html.py

js/bot-rank.js

Uh oh!

TheYoBots left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Nov 27, 2025 •

edited

Loading

`bot_leaderboard.py`

`app.py`

`md2html.py`

`js/bot-rank.js`