Skip to content

refactor: remove nightshift and the queue-drain tooling - #410

Merged
TheWeiHu merged 4 commits into
mainfrom
TheWeiHu/remove-nightshift-queue-runner
Oct 21, 2026
Merged

TheWeiHu merged 4 commits into
mainfrom
TheWeiHu/remove-nightshift-queue-runner

Conversation

@TheWeiHu

Copy link
Copy Markdown
Owner

Summary

  • Remove the nightshift orchestrator (internal/nightshift, CLI verb, worker prompts, skill) and the /work drain skill.
  • Remove everything that only existed to feed it: the dashboard cockpit view, 🌙 moon launcher and task-selection dots, the /api/nightshift* routes and dedicated-clone logic, the git-derived task status (DEVBRAIN_TODO_DERIVE_GIT), the fixed-set fence (DEVBRAIN_TODO_ONLY), the approve and note verbs and the approved field, the turn-marker hook, the nightshift-only session classifier rules and cwd/worktree heuristics, internal/procutil, and the nightshift branch from the pre-push gate.
  • gitx is trimmed to the runner heartbeat uses. /continue, /distill, the queue, and the Typed/Bot toggle (still driven by harness-meta turns) are unchanged.
  • README, docs/architecture.md, CI comment, goreleaser, and the surviving skills drop nightshift. The README GIF is refilmed as a Board → Profile tour (2.08 MB, ~15s).

Net: 109 files, −12.2k lines.

Goldens

testdata/golden is hand-edited only where the removed behavior changed output: the two worker-session prompts in the dashboard fixture are now classified by text (command/human) instead of nightshift, the approved key is gone from todos.json, and the todo CLI golden drops the note/approve steps (task 0003 therefore stays held).

Test plan

  • scripts/test-guard.sh (full suite, guarded) green
  • go test -race -count=3 on dashboard, todo, hooks, gitx
  • both Node dashboard regressions pass
  • GIF refilmed from the rebuilt binary and eyeballed frame-by-frame

🤖 Generated with Claude Code

TheWeiHu and others added 4 commits October 21, 2026 11:46
Drop the orchestrator, the /work skill, the dashboard cockpit and moon
launcher, the git-derived task status, the fixed-set fence, the approve
and note verbs, the turn-marker hook, and the nightshift-only session
classification. The queue, /continue, and /distill are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-ups: historical fleet transcripts and logs must keep importing
and classifying as autonomous, migrate removes the retired work/nightshift
skill dirs and the old toolset dir, the env-scrub test asserts where the
task file lands, and the unrelated gofmt churn is reverted.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@TheWeiHu

Copy link
Copy Markdown
Owner Author

CLAUDE (Fable 5.1): Cross-model review ran (Opus 5.5, high effort, $1.14, local one-shot via the review wrapper). Disposition of its findings, fixed in fix: keep legacy worker-session detection and prune retired skills:

  • Historical fleet data reclassified as typed (Medium ×2) — valid. Restored the classifier's autonomous_*/nightshift_prefixes rules, the importer's /nightshift/·/drain/·-wN path detection, and the live hook's matching rule, all marked as legacy. Old logs and a re-import keep their auto: true rows; the prompt goldens are back to their original values.
  • Stale work/nightshift skill dirs survive an upgrade (Medium) — valid. migrate now removes them from both skill roots; covered in TestInstall….
  • Legacy ~/.claude/nightshift + shim cleanup dropped (Low) — restored.
  • Env-scrub test vacuous (Low) — valid; it now asserts the task file landed under the harness project.
  • .gitignore .nightshift/ (Note) — restored with a legacy comment.
  • Unrelated gofmt churn, mis-indented listener (Notes) — reverted / fixed.
  • clearSel() ReferenceError (High) — not a bug: the Profile IIFE defines its own clearSel.
  • Dead turn-marker Stop hook on existing installs (High) — not a bug: hookSpecs never registered a Stop hook in settings.json; the orchestrator set NIGHTSHIFT_MARKER only in worker worktrees. Nothing calls devbrain hook turn-marker.
  • --without nightshift now errors (Medium) — intended hard break, hence 1.6.0.
  • .card{position:relative} (Low) — only the select dot was absolutely positioned inside a card; nothing else depends on it.

@TheWeiHu
TheWeiHu merged commit 535aea6 into main Oct 21, 2026
3 checks passed
@TheWeiHu
TheWeiHu deleted the TheWeiHu/remove-nightshift-queue-runner branch October 21, 2026 16:53
@TheWeiHu TheWeiHu mentioned this pull request Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant