Skip to content

chore(crcdebug): Log DieOnDetonate on projectile detonation #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Okladnoj wants to merge 1 commit into from
+8 −0
Closed

chore(crcdebug): Log DieOnDetonate on projectile detonation #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Core/GameEngine/Include/Common/CRCDebug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
void addCRCDumpLine(const char *fmt, ...);
void addCRCGenLine(const char *fmt, ...);
#define CRCDEBUG_LOG(x) addCRCDebugLine x
#define CRCDEBUG_LOG_NOCOUNTER(x) addCRCDebugLineNoCounter x
#define CRCDUMP_LOG(x) addCRCDumpLine x
#define CRCGEN_LOG(x) addCRCGenLine x

Expand Down Expand Up @@ -116,6 +117,7 @@
#define DUMPREALNAMED(x, y)

#define CRCDEBUG_LOG(x)
#define CRCDEBUG_LOG_NOCOUNTER(x)
#define CRCDUMP_LOG(x)
#define CRCGEN_LOG(x)

Expand Down
6 changes: 6 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/MissileAIUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "Common/ThingTemplate.h"
#include "Common/RandomValue.h"
#include "Common/BitFlagsIO.h"
#include "Common/CRCDebug.h"

#include "GameLogic/AIPathfind.h"
#include "GameLogic/ExperienceTracker.h"
Expand Down Expand Up @@ -386,6 +387,11 @@ void MissileAIUpdate::detonate()

if (m_detonationWeaponTmpl)
{
// TheSuperHackers @info Okladnoj 03/08/2026 DieOnDetonate decides whether the projectile dies here
// or a frame later in doKillSelfState, which moves its die modules to a different frame. Record it,
// because a client that disagrees on this flag desyncs at the frame the projectile detonates.
Comment thread
Okladnoj marked this conversation as resolved.
CRCDEBUG_LOG_NOCOUNTER(("MissileAIUpdate::detonate() obj=%d weapon=%s dieOnDetonate=%d",
obj->getID(), m_detonationWeaponTmpl->getName().str(), m_detonationWeaponTmpl->getDieOnDetonate() ? 1 : 0));
Comment thread
Okladnoj marked this conversation as resolved.

TheWeaponStore->handleProjectileDetonation(m_detonationWeaponTmpl, obj, obj->getPosition(), m_extraBonusFlags, !m_noDamage );

Expand Down
Loading