bugfix(network): Sort command list fast path by sort number

[CryoTheRenegade]

• Closes NetCommandList::addMessage sorts messages by id using different functions #2795

Changed the cached NetCommandList::addMessage insertion path to use getSortNumber(), matching the full list traversal.

For normal commands this is equivalent to getID(). ACK commands override it with the ID of the command being acknowledged, so using it consistently prevents incorrect ACK ordering.

[Skyaero42]

Starting to look better, but still a few points of attention and some formatting

[Skyaero42]

I don't think this is correct. if candidate->getNetCommandType() < reference->getNetCommandType() it is not supposed to return false, but to move to the next if statement.

I think it should be

if (candidate->getNetCommandType() > reference->getNetCommandType())
{
  return true;
}

if (candidate->getPlayerID() > reference->getPlayerID())
{
  return true;
}

return isCommandIdNewer(candidate->getsortNumber(), msg->reference->getsortNumber());

[CryoTheRenegade]

This is lexicographic: type → player → sort number. A lower type must return false; otherwise (type=1, player=7) could incorrectly sort after (type=2, player=0).

[Skyaero42]

I need a second opinion on this from someone else. You may be correct, but its very different from the original if-statement as well as your original fix (which only replaced id with sortednumber)

[Caball009]

I'm a bit concerned this may affect retail compatibility. Please test this change in a multiplayer match. You can use two local instances, one with the change and one without.

[CryoTheRenegade]

I'm a bit concerned this may affect retail compatibility. Please test this change in a multiplayer match. You can use two local instances, one with the change and one without.

Tested with latest weekly as control, no issues seen (had 2 instances of tracy in the background and nothing weird happened, but im not very good at playing against myself so i didnt stress it out too much :/)