Skip to content

fix(flow): swap 3:4 and 4:3 in the frontend image aspect-ratio enum #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
king-of-Jupiter wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(flow): swap 3:4 and 4:3 in the frontend image aspect-ratio enum #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/services/flow_frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ def _map_frontend_image_aspect_ratio(aspect_ratio: str) -> int:
"IMAGE_ASPECT_RATIO_PORTRAIT": 2,
"IMAGE_ASPECT_RATIO_16_9": 3,
"IMAGE_ASPECT_RATIO_LANDSCAPE": 3,
"IMAGE_ASPECT_RATIO_LANDSCAPE_FOUR_THREE": 4,
"IMAGE_ASPECT_RATIO_PORTRAIT_THREE_FOUR": 5,
"IMAGE_ASPECT_RATIO_LANDSCAPE_FOUR_THREE": 5,
"IMAGE_ASPECT_RATIO_PORTRAIT_THREE_FOUR": 4,
}
try:
return mapping[str(aspect_ratio or "").strip().upper()]
Expand Down
4 changes: 2 additions & 2 deletions tests/test_flow_image_rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ async def test_browser_modes_submit_explicit_models_using_local_captcha(self):
("IMAGE_ASPECT_RATIO_LANDSCAPE", 3),
("IMAGE_ASPECT_RATIO_PORTRAIT", 2),
("IMAGE_ASPECT_RATIO_SQUARE", 1),
("IMAGE_ASPECT_RATIO_LANDSCAPE_FOUR_THREE", 4),
("IMAGE_ASPECT_RATIO_PORTRAIT_THREE_FOUR", 5),
("IMAGE_ASPECT_RATIO_LANDSCAPE_FOUR_THREE", 5),
("IMAGE_ASPECT_RATIO_PORTRAIT_THREE_FOUR", 4),
)
for mode in ("browser", "personal"):
for model in ("BELUGA", "HARBOR_SEAL", "GEM_PIX_2"):
Expand Down