Fix setup of resolver verification#57
Open
jeteon wants to merge 1 commit into
Open
Conversation
Previously, the resolver instance used by the process is set up with no arguments to the constructor but since the signature of the constructor is: ```python def __init__(self, nameservers = ['8.8.8.8','8.8.4.4']) ``` This actually creates a resolver with the Google DNS servers as the nameservers to use. Then, in the blank test on line [227](https://github.com/TheRook/subbrute/blob/c5b96610129bedcb4c322b8864f67985b3e808f8/subbrute.py#L227), a resolution is made for the blank domain as part of the verification: ```python blanktest = self.resolver.query(self.target, self.query_type) ``` However, since no nameserver is explicitly specified, the Google DNS servers are actually used again for this. This means the verification process actually hits the Google servers at least once for every server they verify and don't actually verify the behaviour of the server itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the resolver instance used by the process is set up with no arguments to the constructor but since the signature of the constructor is:
This actually creates a resolver with the Google DNS servers as the nameservers to use. Then, in the blank test on line 227, a resolution is made for the blank domain as part of the verification:
However, since no nameserver is explicitly specified, the Google DNS servers are actually used again for this. This means the verification process actually hits the Google servers at least once for every server they verify and don't actually verify the behaviour of the server itself. This means that if Google's DNS servers start to throttle you then other nameservers will be flagged as having timed out even though they haven't been touched at all.