Added setup.py#29
Open
ALSchwalm wants to merge 1 commit into
Open
Conversation
|
:( WIsh this repo was still active. |
|
Well, it is clear it is not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the conventional
setup.pyfile to make installation a bit easier. I believe this is entirely backwards compatible, so you can still run subbrute directly from the project folder, if desired. However, users can now installsubbruteglobally withsudo python setup.py installor (without root)python setup.py install --user.The wrapper being executed is automatically generated via the entry_points feature of setuptools (this also generates an exe on windows). I added a short section to the README about installation with this script.
Currently, the script is configured to pull the latest dnslib, unless you are running from the project folder (in which case the one in the repo is used). I'm not sure I love this, but it does maintain exactly the existing behavior.
Ultimately, this is a step towards what I think would be the best installation setup: uploading to pypi. Then people can just
pip install subbruteand never touch github. This will only get better in the future, as pip is shipped with current python (3.4+).