Repository navigation
fix(window): inhibit compositor idle during video playback - #98
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
GTK reports a successful idle-inhibit request on Omarchy, but Hyprland still reports
inhibitingIdle=falsewhile video plays. Natural end and seeking also need a consistent playback state before the inhibitor is released.Solution:
Use the Wayland idle-inhibit protocol for the video window when available, with GTK's session inhibit as a fallback. Keep protocol discovery off the GTK blocking path and release inhibition on pause, natural end, navigation, failure and close. Pause the GStreamer pipeline at end of stream, preserve an accepted post-end seek for Play, and add a live Hyprland check. Declare the Wayland build/runtime dependencies and update the relevant documentation.
Tests:
cargo fmt --check,cargo clippy --locked --all-targets -- -D warnings,cargo test --locked(195 passed, 16 ignored), andcargo build --release --locked.avdec_h264software playback.rpmmodule.Note:
Fedora GNOME/Wayland remains the reference environment and needs its CI and real-session checks before a support claim. The checked-in Arch recipe still fetches published v0.1.4, so the fix enters that package only when a new release updates its tag and checksum. Hyprland's
inhibitingIdleflag was checked; a real Omarchy lock/blank timeout and the remaining manual and performance checks are still needed for full compatibility.