Skip to content

fix(viewer): use bundled Lucide controls across desktop themes - #101

Merged
TheRealShek merged 6 commits into
mainfrom
fix/consistent-viewer-icons
Oct 15, 2026
Merged

TheRealShek merged 6 commits into
mainfrom
fix/consistent-viewer-icons

Conversation

@TheRealShek

@TheRealShek TheRealShek commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Problem:
Desktop icon themes change the Viewer controls. Yaru turns Close red and supplies thin, detailed toolbar artwork.

Solution:
Bundle 18 Lucide 1.57.0 SVGs with app-specific names, a plain close symbol and explicit 16px sizing. Preserve Lucide's geometry and strokes while adapting paint attributes for GTK. Apply monochrome hover, focus, pressed and disabled states. Retain upstream notices in the binary and installed license files. Viewing remains offline.

Tests:

  • Passed formatting, Clippy, 195 unit tests and release build. The separate icon test passed 162 theme/size rendering cases. Other desktop/fixture tests remain ignored.
  • Passed seven source-install tests, including notice installation, removal and ownership protection; ShellCheck, shell syntax, desktop-file and AppStream checks. RPM spec validation skipped because rpmspec is unavailable.
  • Inspected actual Arch/Wayland before/after captures. Quick Markup enter/cancel passed. Standards and spec reviews found no actionable issues.

Note:
The author tested the final 16px build on Arch/Wayland, approved its appearance, and requested merge and release. Required Fedora CI passed. Full Fedora/GNOME and actual compositor fractional-scale human testing remain unconfirmed. Two-axis final code review found no blocking issues.

Before and after:
Yaru-blue, the same photo and a 966 × 1056 window.

Before After, Lucide
Before: theme-provided icons After: bundled Lucide icons

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 61ab602c-bf82-41f2-b9c6-beea69329937
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheRealShek TheRealShek changed the title fix(viewer): keep controls monochrome across icon themes fix(viewer): use bundled Lucide controls across desktop themes Oct 15, 2026
@TheRealShek
TheRealShek marked this pull request as ready for review October 15, 2026 05:37
@TheRealShek
TheRealShek merged commit eb2d08a into main Oct 15, 2026
4 checks passed
@TheRealShek
TheRealShek deleted the fix/consistent-viewer-icons branch October 15, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant