Repository navigation
fix(viewer): use bundled Lucide controls across desktop themes - #101
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Desktop icon themes change the Viewer controls. Yaru turns Close red and supplies thin, detailed toolbar artwork.
Solution:
Bundle 18 Lucide 1.57.0 SVGs with app-specific names, a plain close symbol and explicit 16px sizing. Preserve Lucide's geometry and strokes while adapting paint attributes for GTK. Apply monochrome hover, focus, pressed and disabled states. Retain upstream notices in the binary and installed license files. Viewing remains offline.
Tests:
rpmspecis unavailable.Note:
The author tested the final 16px build on Arch/Wayland, approved its appearance, and requested merge and release. Required Fedora CI passed. Full Fedora/GNOME and actual compositor fractional-scale human testing remain unconfirmed. Two-axis final code review found no blocking issues.
Before and after:
Yaru-blue, the same photo and a 966 × 1056 window.