Open
Conversation
Collaborator
Author
|
I did not change any imports in the ipynb however, that should be updated before accepting this PR |
Collaborator
Author
|
Actually, the ipynb builds everything in place, so it looks like there never were any imports from helpers.py - should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ThePattersonian : I asked chat gpt about the helper functions and which were Model, View, or Controller and took a crack at a first factorization - this is obviously temporary, it is likely that instead of individual module py-files, we will end up creating folders for each topic, but this is a start.