feat: adjust other handler for urlreward activity#496
Open
hmcdat wants to merge 2 commits intoTheNetsky:v3from
Open
feat: adjust other handler for urlreward activity#496hmcdat wants to merge 2 commits intoTheNetsky:v3from
hmcdat wants to merge 2 commits intoTheNetsky:v3from
Conversation
Owner
|
Interesting, does the flyout data contain the same data as the regular dashboard? If so, it can be used as an alternative/fallback for the dashboard data. However in this PR you're also commenting out some other things as well as generating a random hash instead of using the one from the activity itself for some reason? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pr, I adjusted the working way of urlreward activity by using panel flyout api, it's still working for me until now