feat(auth): add manual password input when password not configured#495
Open
lucaszhongsj wants to merge 1 commit intoTheNetsky:v3from
Open
feat(auth): add manual password input when password not configured#495lucaszhongsj wants to merge 1 commit intoTheNetsky:v3from
lucaszhongsj wants to merge 1 commit intoTheNetsky:v3from
Conversation
When password is empty or whitespace-only, prompt user to input password manually via terminal (120s timeout), similar to existing TOTP manual input flow. Also adds error message checking after password submission.
Owner
|
Why not just add the password to the accounts file? In what scenario do you want to not add one to the accounts.json and only want to do manual input? |
Author
It's mostly about flexibility. Right now, if a password is missing in accounts.json, the login just fails. A couple of scenarios where this helps:
Up to the user. |
Contributor
|
Wouldn't it be simpler to use Passwordless login? MS already has a flow for users if you don't want to store or expose a plaintext password. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/browser/auth/methods/EmailLogin.ts: Add manual password input support withpromptInpututilityTest plan
No password provided, awaiting manual input