Adding parameters hook function for partition management

[kollanur]

No description provided.

[StellarBot]

Can one of the admins verify this patch?

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[hkaiser]

@kollanur inspect is not happy:

/libs/core/execution/tests/unit/executor_parameters_partition_hooks.cpp: 
    *I* missing #include (functional) for symbol std::ref on line 75, 
    *I* missing #include (hpx/assert.hpp) for symbol HPX_ASSERT on line 39, 
    *I* missing #include (string) for symbol std::string on line 122, 
    *I* missing #include (type_traits) for symbol std::true_type on line 59, 
    *I* missing #include (utility) for symbol std::pair on line 52

[hkaiser]

Should we reduce the size of the enumerator values?

Suggested change

	enum class partition_phase : std::size_t
	enum class partition_phase : std::uint8_t

[hkaiser]

Suggested change

	HPX_ASSERT(partition < self.values_.size());
	HPX_TEST(partition < self.values_.size());

?

[hkaiser]

Should we test that the argument really is partition_phase::begin?