Skip to content

Fix weekly builds: replace msbuild with cmake --build - #74

Merged
TheGoodDoktor merged 7 commits into
masterfrom
copilot/fix-weekly-builds
Jul 28, 2026
Merged

TheGoodDoktor merged 7 commits into
masterfrom
copilot/fix-weekly-builds

Conversation

Copilot AI commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Windows weekly builds fail with MSB1009: Project file does not exist because windows-latest now defaults to the VS 18 (2026) generator, and calling msbuild with a hardcoded .sln filename is fragile against generator changes.

Changes

  • Replace msbuild invocations with cmake --build across all three Windows build steps (ZXSpectrum, C64, CPC):

    - msbuild /m /p:Configuration=${{ env.BUILD_CONFIGURATION }} SpectrumAnalyser.sln
    + cmake --build . --config ${{ env.BUILD_CONFIGURATION }}

    cmake --build delegates to the correct underlying build tool without needing to know the solution filename.

  • Update microsoft/setup-msbuild from v1.0.2 → v2 to eliminate the deprecated set-output warning.

Copilot AI changed the title Fix weekly builds: use cmake --build instead of msbuild Fix weekly builds: replace msbuild with cmake --build Jul 27, 2026
Copilot AI requested a review from TheGoodDoktor July 27, 2026 23:48
@TheGoodDoktor
TheGoodDoktor marked this pull request as ready for review July 28, 2026 00:15
@TheGoodDoktor
TheGoodDoktor merged commit 2d1ad39 into master Jul 28, 2026
3 of 9 checks passed
@TheGoodDoktor
TheGoodDoktor deleted the copilot/fix-weekly-builds branch July 28, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants