fix: authenticate to Docker Hub before setup-qemu-action in release workflow - #88
Merged
Merged
Conversation
…orkflow docker/setup-qemu-action pulls its binfmt image from Docker Hub, but the Docker Hub login step ran after it (and after setup-buildx-action and two other registry logins), so that pull was unauthenticated and hit the shared self-hosted runner's Docker Hub rate limit, failing the v1.4.4 release-image job with "toomanyrequests: You have reached your unauthenticated pull rate limit."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v1.4.4release-image job failed twice with:docker/setup-qemu-action@v4pulls its binfmt image from Docker Hub, but the "Authenticate to Docker Hub" login step ran after it (and aftersetup-buildx-actionand two other registry logins), so that pull was unauthenticated and hit the shared self-hosted runner's Docker Hub rate limit.Fix
Move the Docker Hub login to the first step after checkout, before anything that might pull from Docker Hub.
Test plan
v1.4.4release-image job after merging.