fix: change_cat accepts multiple comma-separated nzo_ids - #83
Closed
thedancingdeveloper wants to merge 1 commit into
Closed
fix: change_cat accepts multiple comma-separated nzo_ids#83thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
Real SABnzbd's _api_change_cat parses `value` as a comma-separated list of nzo_ids via clean_comma_separated_list, applying the category change to all of them. handle_change_cat treated `value` as a single job ID, so a multi-ID request (e.g. bulk re-categorize) matched no job and silently failed for all of them.
4 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #76: real SABnzbd's
_api_change_cataccepts a comma-separated list of nzo_ids invalue, applying the category change to all of them:RustNZB's
handle_change_cattreatedvalueas a single job ID, so a comma-separated multi-ID value (e.g. bulk re-categorize in a queue UI) matched no job and the category change silently failed for all of them.Fix
handle_change_catnow splitsvalueon,and applies the category to every matching job, returning{"status": true}if at least one changed — matching real SABnzbd'sbool(result > 0)semantics.Test plan
cargo test -p nzb-web— addedchange_cat_applies_to_multiple_comma_separated_ids.cargo clippy -p nzb-web --all-targets— clean.nzb-webtest suite passes.🤖 Generated with Claude Code