DataSpell location elements - #1097
Merged
Merged
Conversation
JasperLorelai
requested changes
Aug 24, 2026
Collaborator
|
Since this is an atomic PR (self-contained), you don't need to clear up history because we can merge with squash. |
…aSpell.java Co-authored-by: JasperLorelai <contact@jasperlorelai.eu>
…aSpell.java Co-authored-by: JasperLorelai <contact@jasperlorelai.eu>
…ion.java Co-authored-by: JasperLorelai <contact@jasperlorelai.eu>
…ion.java Co-authored-by: JasperLorelai <contact@jasperlorelai.eu>
JasperLorelai
requested changes
Aug 24, 2026
JasperLorelai
approved these changes
Aug 24, 2026
JasperLorelai
left a comment
JasperLorelai
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now imo, but since we're just about to release, we could delay this for B20?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for targeting both entities and locations:
DataSpellnow implementsTargetedLocationSpelland can cast spells at both entities and locations.castto check for an entity target first, then fall back to a block location target if no entity is found.