Skip to content

Fixed bug when frame connection could be lost#183

Merged
CameronRP merged 1 commit into
TheCacophonyProject:mainfrom
CameronRP:fix-dropping-frame-connection
Jun 8, 2026
Merged

Fixed bug when frame connection could be lost#183
CameronRP merged 1 commit into
TheCacophonyProject:mainfrom
CameronRP:fix-dropping-frame-connection

Conversation

@CameronRP

Copy link
Copy Markdown
Contributor

If tc2-agent was not running when trying to get a frame connection it would return out of the goroutine handling frame socket/connection so the camera preview would be lost until managementd was restarted.

@CameronRP CameronRP requested a review from hardiesoft June 8, 2026 03:08

@hardiesoft hardiesoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that seems reasonable. The prioritiseframeserve is just a hint to tc2-agent that there are people looking at the camera preview, and so now would not be a great time to start offloading low-power mode files from the RP2040 flash. That said, I don't think that functionality is super well tested at the moment, so I can't guarantee its robustness!

@CameronRP CameronRP merged commit b31808d into TheCacophonyProject:main Jun 8, 2026
2 checks passed
@CameronRP CameronRP deleted the fix-dropping-frame-connection branch June 8, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants