Conversation
Podman (via containerd) fetches sub-manifests referenced in an OCI Image Index
via GET /v2/{name}/blobs/{digest}. Manifest blobs were stored in the blobs table
but never inserted into repository_blobs, so BlobsDownload returned 404 for them.
Add repository_blobs insert in HandleUploadManifest. The existing ON CONFLICT
DO NOTHING guard makes this safe for re-pushes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Podman (via containerd) fetches sub-manifests referenced in an OCI Image Index via
GET /v2/{name}/blobs/{digest}(blobs endpoint, not manifests endpoint). Manifest blobs were stored in theblobstable and blob storage but never inserted intorepository_blobs, soBlobsDownloadreturned 404 BLOB_UNKNOWN for them.The fix adds a
repository_blobsinsert inHandleUploadManifest. TheON CONFLICT (repository_id, blob_id) DO NOTHINGguard (added in #55) makes this safe on re-pushes.Test plan
podman push+podman pullsucceeds for OCI Image Index images