fix(oci): store manifests with correct mediaType in blob storage#52
Merged
fix(oci): store manifests with correct mediaType in blob storage#52
Conversation
DownloadBlob overrides Content-Type from blob metadata, but manifests were always stored with the hardcoded OCI content type regardless of their actual type. This caused Docker v2 manifests to be served with Content-Type: application/vnd.oci.image.manifest.v1+json while the JSON body contained mediaType: application/vnd.docker.distribution.manifest.v2+json, triggering Docker's "if present, mediaType in manifest should be" error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DownloadBlobin both storage backends overrides theContent-Typeresponse header from blob metadataBlobContentTypeManifest = "application/vnd.oci.image.manifest.v1+json"constant, regardless of their actual typeContent-Type: application/vnd.oci.image.manifest.v1+jsonwhile the JSON body contained"mediaType": "application/vnd.docker.distribution.manifest.v2+json", triggering Docker's "if present, mediaType in manifest should be..." error ondocker pullMediaTypeas the blob content type when uploading, soDownloadBlobsets the correctContent-TypeTest plan
docker pusha Docker image to Dockyard, thendocker pullit — should succeed without the mediaType errordocker pushan OCI image, thendocker pull— should still workContent-Typeresponse header onGET /v2/.../manifests/...matches the manifest's mediaType