Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects docstring parameter descriptions across the nhp.data Spark ETL/data-access modules, clarifying that the spark parameter is a SparkSession (not a Spark context).
Changes:
- Updated
:param spark:docstring text from “Spark context” to “Spark session” in multiple functions to match the actualSparkSessiontype hints.
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/nhp/data/reference/population_by_imd_decile.py | Docstring clarifies spark is a Spark session. |
| src/nhp/data/reference/icb_catchments.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/population_projections/npp.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/nhp_datasets/providers.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/nhp_datasets/local_authorities.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/nhp_datasets/icbs.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/model_data/op.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/model_data/ip.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/model_data/inequalities.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/model_data/demographic_factors.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/model_data/birth_factors.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/model_data/aae.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/rates.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/procedures.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/op/rates.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/op/procedures.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/op/expat_repat.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/op/diagnoses.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/op/baseline.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/op/init.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ip/rates.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ip/procedures.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ip/expat_repat.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ip/diagnoses.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ip/baseline.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ip/init.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/inequalities.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/expat_repat.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/diagnoses.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/baseline.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ae/rates.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ae/procedures.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ae/expat_repat.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ae/diagnoses.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ae/baseline.py | Docstring updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/ae/init.py | Docstrings updated to refer to Spark session for spark param. |
| src/nhp/data/inputs_data/acute_providers.py | Docstrings updated to refer to Spark session for spark param. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yiwen-h
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used Spark context, when it is actually the spark session