Repository navigation
Build expanded English public gonol and recursive ordinal construction - #88
erinepshovel-code wants to merge 25 commits into
Conversation
…dinal construction
Actual complete-corpus construction and replayRun Observed artifact results:
Actual construction artifact: Canonical public-registry digest: The subsequent integration head hmmm: Both PRs remain unmerged. Layout recipes are explicit profile choices. Native Möbius lift, global frame transport and semantic inference are not established by local construction/recovery success. Actions artifacts have 30-day retention; downloaded construction copies remain separate from that retention window. |
…se unresolved laws Operator-authorized replacement. Add a no-fallback package entrypoint and source-owned active selection, nine routing regressions, updated usage, manual full-build dispatch, and prioritized construction questions. Preserve the byte-sealed admission dependency closure and previous geometry receipts as historical support; do not label legacy outputs as new geometry. UCNS #241 merged at 6ebbf970ad13a0d2e1c13bd65c496b671e740185; consume the same exact producer bytes. Local focused regression: 49 passed. Root authority, libs pins, and UCHC release standing unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e0ea9ebe6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…guage boundaries Register the selected source and six exact input roles in root machine/human projections; update English BASE without rewriting extraction provenance or libs snapshots. Restore identity, recursive scale and EDCM measurement-only clauses caught by unchanged language-authority tests. Add source-registration/digest regression. Local focused rerun: 50 passed. Geometry and the thirteen-file admission closure remain unchanged.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c9470d90c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ission CI inputs Repair the three remaining #88 review findings. Admit only the two complete pinned Unicode 18.0.0 file hashes; synthetic parser/layout fixtures cannot be called the release. Enforce exact manifest schema and fixed uncertainty claims before replay, reject false extra status fields and malformed counts/receipts, and emit source-owned boundary text. Include the entire admission module closure in the full-corpus workflow path filter. Local focused regression: 64 passed. Complete retained UCD bytes passed the new public loader. Full hosted reconstruction is required for this changed verifier implementation; previous manifest receipts are not promoted.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dea37abee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Snapshot only regular nonsymlink UCD files, reject oversize inputs before open, retain at most the limit plus one byte, detect file replacement/growth, and authenticate the bounded snapshot before building or copying. Ordinal placement, public layout and SPACE-first behavior are unchanged. Runtime source checkpoint for the following atomic provenance/test/CI update; no branch ref moves at this checkpoint.
Close the four further #88 findings in one source-plus-metadata transaction. Select exact runtime checkpoint 37adccb in BASE and root projections, recompute the work graph, compare selected module bytes in CI, retain separate source-head and tested-merge evidence, and scope prior corpus claims to their original implementation. Add bounded-read/special-file/race and workflow proof regressions. Local focused suite: 73 passed. Runtime implementation SHA-256 a1933daabd2ae9323588c99f395441c7711e082ea03c97797a81051b1430aa2d. Full final-head construction and merge-tree replay required before merge; previous artifacts are not relabeled.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 174f96a724
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…h from geometry data Byte-bind ACTIVE_CONSTRUCTION.json and the local source work graph alongside both runtime modules to the selected source checkpoint. Trigger the full gate on BASE and root-manifest changes. Keep the work graph as explicitly separate source CI evidence, not an unverified authority record inside the construction artifact. Add three regressions and document the verification boundary. Local focused suite: 76 passed. Runtime bytes and selected source 37adccb remain unchanged; final merge-tree CI still required.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7f8672e15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69559d3c90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ents Record operator answer 3: not required. Preserve SPACE attachment answers and outstanding witnesses; leave questions 4 and 5 open. Align README and construction guide without changing runtime, source pins, or UCNS native geometry. Applies skill-lib gonol-build scope preservation and the-interdependency workflow.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee130be775
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Record answer 4: reuse the previous definition method and applicable functions; reconstruct over the expanded carrier rather than redesign semantics. Bind the inspected prior definition sources, preserve overlapping roles and honest unknowns, and specify old/new preservation and no-fallback witnesses. Only vocabulary growth remains a construction question. Documentation only: no runtime, source-pin, test, workflow or generated-artifact changes. Applies gonol-build structure preservation, the-interdependency source-first inheritance, and WDLL evidence separation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14341800a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34fdda574f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Apply operator answer 4 in executable build and independent verification: preserve the unchanged definition table and final-y behavior, expand carrier coverage, and require source-bound character-definitions.json with no historical geometry fallback. Add 19 definition/integration cases; update manifest fixture and isolated CI coverage. Preserve concurrent baseline-owned admission and package-isolation repairs. Acquire Unicode before verifying artifact identities. Local focused suite: 85 passed with the unused historical constructor import poisoned. Complete supplied-field definition replay: 4698 characters, 4757 definition closures, ten number-name interiors matching corpus word receipts, 4643 explicit unknowns. This is not current-head hosted/full-admission evidence. Applies wdll, gonol-build, msdmd, meta-module-build and stack-update. Source repinning follows in the same guarded branch transaction.
Pin active runtime to 2ba7131 in BASE and both root projections. Recompute the work-graph digest and correct stale native Mobius/operator boundaries. Preserve canonical libs pins and all unrelated participants. The parent contains executable definition migration and local witnesses; this provenance-only commit adds no hosted CI or full-corpus certification.
Address PR #88 review 4270796319: every declared participant must map exactly once to an acquired input or the baseline whose sealed closure is checked. Reject unknown, repinned, duplicate and omitted identities; explicitly verify the fetched Stack baseline commit. Five local positive/adversarial cases passed against the exact participant-loop excerpt; committed tests extract the real workflow loop in repository CI. No runtime, selection, work-graph or canonical source-pin bytes change. Complete current-head hosted evidence remains required.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08ccfe65a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert keyed['ordinal-unicode-data']['artifact_sha256'] == implementation.UCD_RELEASE_SHA256['UnicodeData.txt'] | ||
| assert keyed['ordinal-unicode-math']['artifact_sha256'] == implementation.UCD_RELEASE_SHA256['DerivedCoreProperties.txt'] |
There was a problem hiding this comment.
Whenever either English workflow runs test_active_inputs_are_registered_in_root_provenance, this assertion raises NameError because the file imports the module as ordinal_construct, but implementation is never defined. The provenance test therefore always fails instead of validating the Unicode identities; use the imported module name or introduce the intended alias.
Useful? React with 👍 / 👎.
| assert set(inputs) == {'english_gonol/ordinal_construct.py', 'english_gonol/__main__.py', | ||
| 'ACTIVE_CONSTRUCTION.json', 'docs/ordinal-work-graph.json'} |
There was a problem hiding this comment.
The workflow's relative tuple now contains seven entries, including ordinal_definitions.py and both inherited-definition inputs, while this assertion still expects the previous four-entry set. Consequently, test_selection_and_source_graph_are_exact_pinned_inputs fails on every run of both English workflows even after the preceding NameError is fixed; update this expected set to match the newly sealed inventory.
Useful? React with 👍 / 👎.
| manifest = _json_read(output / 'manifest.json') | ||
| _validate_manifest(manifest) | ||
| from english_gonol.structural_construct import _verified_connection, open_readonly, _schema | ||
| with _verified_connection(output / 'admission') as verified: |
There was a problem hiding this comment.
Fresh evidence beyond the earlier bounded-JSON fix is that verifying an unpacked artifact enters _verified_connection here, and that helper still reads output/admission/manifest.json with an unrestricted read_bytes() in structural_construct.py. If this nested manifest is a large regular file, FIFO, device, or symlink, verify() can still exhaust memory or block before validation; route this nested manifest through the same bounded, nonsymlink reader used for the top-level JSON artifacts.
Useful? React with 👍 / 👎.
| for relative in ('english_gonol/ordinal_construct.py','english_gonol/__main__.py', | ||
| 'english_gonol/ordinal_definitions.py', | ||
| 'english_gonol/language/character_definitions.py', | ||
| 'english_gonol/language/data/character_definitions_v1.json', | ||
| 'ACTIVE_CONSTRUCTION.json','docs/ordinal-work-graph.json'): |
There was a problem hiding this comment.
Fresh evidence after the earlier admission-closure fix is that the new ordinal_definitions.py imports language.character_definitions, which imports english_gonol/gonol.py, but this selected-source list omits gonol.py and the baseline IMPLEMENTATION_FILES inventory omits it as well. A PR can therefore change that import-time dependency, run altered bytes in the full build, and still pass the exact-source comparison while the graph claims the pinned ordinal-source identity; include the complete new import closure and repin the projections.
AGENTS.md reference: AGENTS.md:L72-L75
Useful? React with 👍 / 👎.
| - 'research/english-gonol/docs/ordinal-*' | ||
| - '.github/workflows/english-ordinal-affixiation.yml' |
There was a problem hiding this comment.
When a PR changes only experiments/ordinal-definitions/migration-witness.json, this full workflow is not triggered because the path filters cover ordinal docs, tests, and implementation files but not the committed witness. The general English workflow does run, but none of its fixture-based ordinal tests recomputes the witness's full-field counts, receipts, source hashes, or SURVIVED status, so those evidence claims can drift without either the selected-source check or a complete definition replay; watch this file and compare it against the reconstruction produced from the pinned inputs.
Useful? React with 👍 / 👎.
| graph=json.loads(pathlib.Path('research/english-gonol/docs/ordinal-work-graph.json').read_text()) | ||
| body={k:graph[k] for k in ('repositories','boundaries')} | ||
| assert hashlib.sha256(json.dumps(body,sort_keys=True,separators=(',',':')).encode()).hexdigest()==graph['work_graph_sha256'] |
There was a problem hiding this comment.
When a provenance repin changes ordinal-work-graph.json, this check proves only that its repositories and boundaries reproduce its own digest; it never validates the graph schema/version or requires the non-transfer fields to remain false. A repin can therefore set authority_transfer or proof_status_transfer to true, recompute the digest, and pass this job while the root projections still declare non-transfer boundaries; validate the exact graph shape and reconcile its fixed boundaries with the root manifest before retaining it as evidence.
AGENTS.md reference: AGENTS.md:L72-L75
Useful? React with 👍 / 👎.
1 participant
Authorization and selected construction
Operator: merge, retire the previous completed geometry, replace it with this construction.
english.ordinal/1is the supported default, without legacy fallback. Radius is R/2**(n-i), zero-based; angle comes from the declared expanded carrier. Ordered interiors, repeated occurrences, whitespace and source provenance survive. UCNS #241's exact consumed producer isa7bfa0c96daca1f7445ba57c39fa6d8fd62e51eb.Settled answers: 1. SPACE; 2. SPACE; 3. native Mobius integration not required; 4. reuse prior definitions/functions on the new base. Question 5, vocabulary growth, remains open and does not prevent using the fixed complete corpus.
Executable definition migration
Runtime commit:
2ba7131c5931cccbd779ed08b59f8a2a356729d4.Provenance head:
3c8e405edcb960ac80e6630609b82d62c301d885.ordinal_definitions.pyconsumes the unchanged previous definition table and final-y behavior. It iterates the expanded carrier, preserves overlapping roles and number-name links, and constructs all character/definition interiors through UCNS ordinal affixiation. It never calls the historical constructor. Missing source definitions stay explicit hmmm.The supported build requires
character-definitions.jsonand binds its receipt in the geometry manifest. Verification independently replays its entries, source, positions and nested receipts. Missing, extra, reordered or altered components fail. Previous artifacts require explicit rebuild; historical receipts do not certify this runtime.File plan, risks and witnesses
english_gonol/ordinal_construct.pyenglish_gonol/ordinal_definitions.py(new)tests/test_ordinal_definitions.py(new),tests/test_ordinal_construct.py,tests/test_active_construction.py__main__.py,ACTIVE_CONSTRUCTION.jsonBASE.json, root manifests, ordinal work graphAll paths above are relative to
research/english-gonol/except workflows and root manifests. The source-admission helper closure is retained unchanged as support, not a competing completed geometry. Physical helper separation and downstream consumer migrations remain separate work.Executed evidence
85 local focused checks passed: the new definition cases, current ordinal cases and exact packaged UCNS ordinal tests. The local harness poisoned the unused historical constructor import. This is scoped local evidence, not whole-repository CI.
Complete supplied-field definition replay covered 4,698 characters, 4,757 definition closures and all ten number-name interiors, using the full 103,053-word source inventory. All ten word-interior receipts matched the supplied complete geometry. The inherited source leaves 4,643 scalar definitions explicitly unresolved. See
experiments/ordinal-definitions/migration-witness.jsonfor source hashes, implementation hash, receipt and scope. This run is not a new full-corpus source-admission replay.New root work-graph digest:
a28ff770ccb5c7cdae017272dd47e3bacb0b7054b07ebe7086fe26d534aaebb6.Current-head gates and hmmm
Current-head hosted construction/replay, applicable checks and review must be observed before a guarded merge. Earlier successful runs are historical checkpoints only. Source integration is not UCHC release, downstream deployment, semantic usefulness or measurement validation. SPACE references are settled while global transport witnesses remain engineering work; native Mobius integration is excluded. Source-uncovered definitions and vocabulary growth remain explicit, not invented.