Skip to content

feat(weave): complete native sequence cycle and repair review findings - #77

Merged
erinepshovel-code merged 15 commits into
mainfrom
weave-numeral-construction
Oct 6, 2026
Merged

erinepshovel-code merged 15 commits into
mainfrom
weave-numeral-construction

Conversation

@erinepshovel-code

@erinepshovel-code erinepshovel-code commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Current repair head: cd6a1ff

The corrected research cycle executes corpus normalization once, repeated multi-byte sequence discovery/affixiation, native eighth/whole-circle attachments and seven occurrence-circle streams, exact integer/Unicode references, prime-derived bit partitions and first/last interleaving through repeated rounds. Exact recovery uses no original plaintext or hidden encoder trace. This is construction research, not established asymmetric encryption.

Repair closure

All original and later reported findings have targeted repairs and regressions: accounting and aggregate work budgets; Stack/UCNS/UCHC ownership; exact native records and canonical scalar fields; trusted validation/serialization/geometry dispatch; complete capped-LCP occurrence discovery; deterministic discovery/profile enforcement on recovery; atomic no-clobber output with failure cleanup; and cheap outer-header admission before expensive recovery.

The latest two P2 findings from07ac are repaired here:

  • Decode parses all definitions into decoder-owned deferred data, checks complete cheap metadata, recipe shapes, uniqueness, references, declared length and framing, then evaluates each accepted recipe once under the aggregate engine. No fabricated bit values or persistent validation flags are introduced. Same-budget encode/decode recovery is preserved.
  • Public normalize/denormalize validate Profile through trusted class operations before field use. Affix/unaffix close the equivalent RoundSpec boundary before discovery or decoding. Frozen-record mutation and instance-method shadowing do not bypass admission.

No discarded per-bit codec, substitute cipher, universal geometric law or ownership transfer is introduced. Trusted runtime classes and producer modules remain outside the untrusted-data boundary; this is not an arbitrary-Python sandbox.

Observed local evidence

176 tests passed, zero failures/errors/skips; source unchanged. Eight new admission/helper regressions fail on07ac with32 subtest failures and2 errors, then pass after repair. Exact source/profile/native-lock SHA-256: 607a9af7c0d749d5ab1233b260906a2dfa0d0c50c22abc4a186ed6142dc188b8. All six published repair files match tested local bytes. Historical test counts are explicitly labeled as checkpoints.

The cycle demo remains 784 original → 1,024 normalized → 910 → 1,669 → 6,632 payload +103 framing =6,735 total bytes, exact recovery. It expands overall; no fixed doubling or universal compression is claimed. Hosted exact-head, integration and terminal review remain separate gates.

Authority and compatibility

Stack binary source remains pinned to blob 6a6ba9f57b83b62116a57113a5c6358fab7e7831. UCNS 905e66964a495d7596a577bb64e4158db9465864 supplies unchanged native geometry. UCHC 4ad94e92be10d2c4c875a848addfda46f3c7cfdb is an architecture/migration reference, not a graduated binary runtime. Withdrawn UCHC#7 remains preserved with provenance and notices.

Latest repairs change no native-source lock, wire format, profile formula or valid recovery result. Earlier native-lock rotations still require regeneration of records bound to older sources. Work is counted without resetting counters or demanding redundant decoder evaluation.

Usage

cd research/weave
python cycle.py demo --sources /checkouts
python cycle.py forward input.bin output.wvc --corpus corpus.bin --sources /checkouts
python cycle.py reverse output.wvc recovered.bin --corpus corpus.bin --sources /checkouts
WEAVE_SOURCES=/checkouts python test.py --receipt /tmp/weave-check.json
WEAVE_SOURCES=/checkouts python -m unittest discover -s tests -p test_admission_order.py -v

Only the locked UCNS source is required. CYCLE.md records profiles, accounting, budgets, source ownership and rollback.

hmmm

Private/public derivation and recovery advantage, authentication/replay, automatic compact prime-recipe discovery and full-cipher security remain unfinished. Terminal review request 6014837855 binds this head and base d0e76d58f832a5664578af39103cdd0697c091d3; merge remains conditional on completed current-revision review and applicable checks.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T11:08:00.782881Z cd6a1ff Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

Observed validation at f547d75

Exact-head push workflow 37343886087, job 111877502822, completed successfully. Its log confirms checkout of that exact SHA and 89 tests passed, 0 failures, 0 errors, 0 skips, source unchanged. Workspace source/profile SHA-256: f056e6862cc9d125e7efba9ddcc0a11209f039b846bf52f0c208ebd2cc878a94.

The logged hashes for numeral.py, tests/test_numeral.py, and the modified test.py match the local files byte-for-byte. The three standalone measurements were rerun locally on those source bytes and retained the documented totals: 1,048,613 bytes for one large literal; 1,048,622 bytes for four references; 40 bytes for the small executed prime recipe.

Separately, PR-isolation workflows 37343953019 (Weave modular experiments) and 37343953207 (stack-consistency) completed successfully. PR merge-ref validation is not being confused with exact branch-head validation. Fifteen new component tests also pass locally, including source-deleted fresh-process recovery.

This is evidence of the numerical-reference construction and regression compatibility, not native gonol construction, encryption, universal compression, or an independent research review. PR remains open; no merge is claimed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f547d755dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/SPECIFICATION.md
Comment thread research/weave/numeral.py Outdated
Comment thread research/weave/numeral.py Outdated
Comment thread research/weave/numeral.py Outdated
@erinepshovel-code erinepshovel-code changed the title feat(weave): construct exact numeral references and prime-path replay feat(weave): complete native sequence cycle and numeral construction Oct 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f63335625

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/CYCLE_WORK_GRAPH.json Outdated
Comment thread research/weave/cycle.py Outdated
Comment thread research/weave/numeral.py
Preserve exact UCNS geometry and UCHC architecture without prematurely shipping a binary UCHC domain. Validate full sequence closures, load fresh verified source, install outputs atomically without clobber, validate empty-input attachments, and reconcile Stack manifests.

Local evidence: 125 tests passed, zero failures/errors/skips. Source profile digest 4f2e432b4ccf5c803e5438e2a26f266c7c0812dd9bde9f05f6090904fd49789f. Hosted checks remain a separate gate.
@erinepshovel-code erinepshovel-code changed the title feat(weave): complete native sequence cycle and numeral construction feat(weave): complete native sequence cycle and repair review findings Oct 5, 2026

erinepshovel-code commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Review-resolution evidence at c360b92

The seven existing review threads are repaired in this exact head:

  1. 4186641936 (active circle-rule drift): SPECIFICATION §5.1, QUESTIONS, EIGHT_CIRCLE, CYCLE, workspace README and historical assembly/transport notices agree on repeated multi-byte sequence/occurrence construction. Obsolete bit-per-circle modules and tests remain removed.
  2. 4186641943 (aggregate prime work): numeral decode passes its charged engine through validation; test_decode_has_one_aggregate_prime_budget exercises the boundary.
  3. 4186641966 (1/0 CLI): argparse's fraction converter gives a concise status-2 refusal; test_zero_denominator_cli_is_concise_refusal passes.
  4. 4186641969 (malformed vs resource): shape/type errors are Refused, exhausted budgets are ResourceLimit; test_malformed_structures_are_not_capacity_failures passes.
  5. 4187186734 (root producer edges): both manifests record UCNS 905e669 geometry and UCHC 4ad94e9 architecture-only inputs, with Stack retaining binary candidate ownership. Root digest is recomputed; the new manifest-edge test and hosted stack-consistency pass. Premature UCHC Add durable MSDMD orchestration slice #7 is closed without merging; repaired source and provenance are retained here.
  6. 4187186753 (partial output): safe_output.write_new writes/fsyncs/closes a private temporary sibling before atomic no-clobber installation. Regressions cover write, short-write, flush, fsync, close, link failure, existing files/symlinks and both cycle CLI directions.
  7. 4187186766 (empty bind): attachment validation runs before empty-input special-casing; invalid angle/circle arguments refuse with status 2 and create no destination.

Full local source-bound suite: 125 passed, no failures/errors/skips. Repaired Weave PR-isolation run 37382500166 and Stack-consistency run 37382500237 completed successfully. Other integration checks and current review are separate gates; this comment is not merge admission or independent security review.

The UCHC closure and mutable-module findings are covered by preserved source and new regression tests, not dismissed because the candidate changed folders. Full source/profile digest: 4f2e432b4ccf5c803e5438e2a26f266c7c0812dd9bde9f05f6090904fd49789f.

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head c360b92e101ff4ac2af7dc33155edec95d7f5887 against base d0e76d58f832a5664578af39103cdd0697c091d3. All seven earlier threads have source-backed repairs and regression evidence in the preceding comment. Focus on complete native closure validation, verified module isolation, failed-write cleanup, correct Stack/UCHC ownership, manifests/source locks, and fidelity to the current repeated multi-byte sequence cycle. Preserve the distinction between reversible research construction and unimplemented asymmetric security.

Copy link
Copy Markdown
Contributor Author

The final head is now fe7cfabebb40f51fb81e3d46f853173680560d1d. The sole delta from the requested-review head c360b92e101ff4ac2af7dc33155edec95d7f5887 is the Weave artifact-upload dependency: deprecated Node20 action ea165f8... is replaced by immutable actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a (official v7.0.1, action.yml runs.using=node24). Archive semantics, read-only permissions, retention and source/test commands remain unchanged. No application/test/profile/native-source bytes changed; source/profile digest remains 4f2e432b4ccf5c803e5438e2a26f266c7c0812dd9bde9f05f6090904fd49789f.

Exact push run 37382494343 on c360 passed 125 tests and the full-cost 6,735-byte demo; all 13 observed checks completed successfully. New-head hosted gates are running separately. The extracted runnable bundle also passed its own full 125-test execution using only bundled sources, with no installation or network. This does not constitute a second independent implementation or a security result.

Copy link
Copy Markdown
Contributor Author

Verified construction delivery at fe7cfab

Exact-head push run 37383446659 / job 112010847516 passed all 125 tests, zero failures/errors/skips. Artifact 11375847849 (SHA-256 819b08d91bd006b60f360abef37da2755c88136740fc83a844977bea45acfcf9) was downloaded and inspected. Its STACK_HEAD is this exact commit, its native UCNS identity is the declared producer, and every runtime/test/profile/native source byte matches the delivered runnable bundle. The bundle's own fresh full-suite replay also passed 125 tests without installing packages or using network.

All eight observed PR-triggered workflows completed successfully on this head: Weave, stack-consistency, UCHC integration, EPAC release consumption, Python Gonol, ZFAE, PSFR, and from-photons-to-macroverse. CodeQL completed successfully with no new alerts. The artifact uploader now uses a source-verified immutable Node24 release rather than the deprecated Node20 runtime.

Exact source/profile SHA-256 remains 4f2e432b4ccf5c803e5438e2a26f266c7c0812dd9bde9f05f6090904fd49789f.

The actual three-round demo recovered exactly: 784 original bytes → 1,024 normalized → 910 → 1,669 → 6,632 payload bytes + 103 outer bytes = 6,735 complete bytes. Definitions, native positions and framing are included; this case expands overall.

The seven earlier review threads are repaired and resolved. The current Codex review on fe7cfab was still running at this delivery check, so no merge or review completion is claimed. UCHC #7 was closed without merging; its repaired binary candidate and 13 tests remain preserved in Stack with provenance and notices.

hmmm: the delivered object is the declared normalization/affixiation/prime-scheduled interleave cycle and exact inverse. It is not an asymmetric cryptosystem, authentication mechanism, or universal compressor.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe7cfabebb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/numeral.py Outdated
Comment thread research/weave/affixiation.py Outdated
Comment thread research/weave/native_binary.py Outdated
Comment thread research/weave/cycle.py Outdated
Reuse accounting validation and share CLI prime-work budgets; correct discovery closure ownership; reject equality-spoofed native records and scalar subclasses using exact producer types and canonical fields; enforce the selected discovery profile during recovery.

Add 11 regression methods, update source lock and documented count. Baseline: 125 tests pass. Repaired exact local source: 136 pass, zero failures/errors/skips; source digest 87c6e30f0ab68259391518c421a6bf340d3be174d9b75baf14f4986373b0bf2c. Three-round demo remains 6735 bytes with exact recovery. Hosted CI and final review are separate gates. No cipher/profile/producer authority change.

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head d3c60e45a2570ca873093b6beaa88662abd3cb68 against base d0e76d58f832a5664578af39103cdd0697c091d3. All four findings from review 5421556730 are repaired; source/profile digest 87c6e30f0ab68259391518c421a6bf340d3be174d9b75baf14f4986373b0bf2c.

  • 4189637562: accounting obtains bit count from the one _parts validation; shared command engine covers decode/accounting/restore. Tests verify exact prime-work thresholds and no output on refusal.
  • 4189637575: discovery documentation now assigns closure to Stack-owned native_binary.py using UCNS geometry, with UCHC only the architecture reference.
  • 4189637581: exact producer-native types and typed scalar/enum fields precede canonical comparison. Tests attack all six native-record slots, nested scalar subclasses, foreign Geometry instances and bypassed frozen records across all export paths.
  • 4189637592: unaffix replays the selected discovery profile and compares definitions plus source order. Tests reject single-byte, single-literal and reordered-definition alternate partitions, including full reverse, while accepting canonical records and enforcing visit budgets.

All 136 tests passed locally with no failures/errors/skips; the 11 new methods first exposed the old defects. The three-round demo still recovers exactly at 6,735 total bytes. No forward profile, UCNS producer, corpus mechanism, authority or security standing changed. Hosted results and this terminal review remain separate merge gates.

Copy link
Copy Markdown
Contributor Author

@codex review

Final exact head is e006fca3644b4b2627f39c8ffb5b25178b8c5d02, base d0e76d58f832a5664578af39103cdd0697c091d3. Its net delta from requested head d3c60e45a2570ca873093b6beaa88662abd3cb68 is one CHECKS metadata correction: the canonical-recovery witness now names the existing cycle_reversible_rounds contract. The runtime, profile and all executable test bodies are unchanged. All eleven added CHECKS entries were statically audited: contract references and executable targets resolve.

The final full local suite was rerun: 136 passed; zero failures, errors or skips, source unchanged. Exact source/profile/native-lock SHA-256 is now 383ca4ed1554a0efe62d75f6795b885c60383d6ce79616f964b6db439e7acd20. Test blob 2d012be906120849d9388680a3e6039ddfa46eb4 matches the locally tested file.

The four repaired findings and their regression evidence are in comment 6008479361. All four threads are resolved. Please anchor terminal review to this head/base pair; do not infer security or graduation from the repair.

Close the remaining instance-shadow route within native-record finding 4189637581 by invoking trusted ClosedSequence and Occurrence class validators directly. Add a regression for definition and occurrence shadowing, update the native source lock, and retain all four repairs without changing the forward profile or UCNS sources.

Observed local full suite: 137 passed, zero failures/errors/skips, source unchanged. Source/profile/native-lock SHA-256: 39684d99cb2e8a4373ecd3279c999cb633d483721cd96fd8140a5b5e7004f309. Hosted checks and exact-head review remain separate gates.

Copy link
Copy Markdown
Contributor Author

@codex review

Terminal review requested at f672bb2, base d0e76d5. This supersedes the e006 review target.

All four P2 findings remain repaired. One additional targeted regression exposed a remaining route in 4189637581: a supplied record could shadow its own post_init method and evade scalar validation. SequenceTable now invokes the trusted ClosedSequence and Occurrence class validators directly, without calling methods supplied by record instances. This rejects both equality-spoofed fields and validator shadowing. The native source lock now binds a917287bdb8bddf239cb48313abd865b2be635c4.

The complete local suite passed 137 tests, zero failures/errors/skips, with unchanged sources throughout the run. The 12 new review-closure methods cover the four findings and the instance-shadow route. Source/profile/native-lock SHA-256: 39684d99cb2e8a4373ecd3279c999cb633d483721cd96fd8140a5b5e7004f309.

The follow-up changes five files, with published blobs matching the locally tested bytes. The public/private design, sequence selection profile, bit interleave, corpus configuration, producer commits and ownership are unchanged. Hosted checks and this exact-head review remain mandatory before the authorized merge. Construction recovery is not an encryption-security result.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f672bb227e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/native_binary.py Outdated
Comment thread research/weave/numeral.py Outdated
Invoke trusted SequenceTable, Packet and Entry validators; use trusted BitBlock conversion and PrimePath replay; revalidate bit fields and require exact opcode strings. Close both final-review findings without changing the forward profile, UCNS geometry or authority. Bound the protection to supplied records, not arbitrary replacement of runtime classes.

Six new regression methods exposed the prior bypasses. Full local and fresh-bundle suites: 143 passed, zero failures/errors/skips, source unchanged. Source/profile/native-lock SHA-256: cebb5d274a21d0cc774f5e387f5bae9c36fded7101f42efad122ce52524a92e9. Native source blob: 5a8adb6. Hosted checks and exact-head review remain separate gates.

Copy link
Copy Markdown
Contributor Author

@codex review

Final source 97915a3, base d0e76d5. This supersedes f672.

The two follow-up P2s are repaired:

  • 4191224454: SequenceTable construction and all three exports invoke SequenceTable.validate(self), not record-owned dispatch.
  • 4191224460: Packet invokes Entry.validate(entry, ...) directly. The same bypass pattern is closed for Packet validation, BitBlock conversion/field validation, and PrimePath replay/opcode dispatch.

Six additional regressions first exposed these gaps, then passed after repair. They exercise table corruption, invalid entries, enclosing packet overrides, altered literal conversion, mutated block scalars and replaced recipe replay. Valid supplied records with harmless method overrides still recover correctly; malformed fields fail through trusted operations. This is explicitly a supplied-record boundary, not a sandbox against replacing trusted runtime classes or producer modules.

The original four repairs remain intact. Full local suite and fresh runnable-bundle suite each passed 143 tests, zero failures/errors/skips, unchanged sources. Eighteen review-closure methods now supplement the 125-test baseline. Source/profile/native-lock SHA-256: cebb5d274a21d0cc774f5e387f5bae9c36fded7101f42efad122ce52524a92e9; native candidate blob 5a8adb61297d328d69f9efeb19053315059bef43.

All seven published follow-up blobs match the tested files. Forward profile, original operations, producer commits and ownership are unchanged. Hosted checks and terminal review must pass at this head/base before the authorized merge; construction/recovery is not a security claim.

Copy link
Copy Markdown
Contributor Author

Verified repair evidence at 97915a3

Exact-head push run 37409467589 succeeded. Artifact 11387893897 was downloaded and inspected; ZIP SHA-256 15ec47da7bca12103c5c881032ad05d7f5dc6e4b88f3255607414628db8775f3. Its STACK_HEAD is this exact commit. 143 tests passed, no failures/errors/skips, sources unchanged. The local source suite, fresh runnable bundle and hosted receipt all match source/profile/native-lock digest cebb5d274a21d0cc774f5e387f5bae9c36fded7101f42efad122ce52524a92e9.

All 55 shared source/document files and both locked UCNS modules compare byte-for-byte between hosted source and the repaired bundle. All 18 new CHECKS entries resolve their declared contracts and executable test targets. The same three-round demo recovers exactly at 6,735 total bytes, counting all records.

All eight observed PR workflows completed successfully: Weave 37409471654, Stack consistency 37409471682, UCHC 37409471673, EPAC 37409471711, Python 37409471731, ZFAE 37409471713, PSFR 37409471701, photons 37409471674. CodeQL 112094546904 completed successfully with no new alerts.

All reported threads have been repaired and resolved; fresh terminal review at this head/base remains the final admission check. No merge is claimed by this evidence comment. Native cryptographic construction, authentication and asymmetric advantage remain separate unresolved work.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97915a3923

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/native_binary.py Outdated
Comment thread research/weave/cycle.py Outdated
Comment thread research/weave/affixiation.py Outdated
Comment thread research/weave/cycle.py
Comment thread research/weave/prime_schedule.py Outdated
…on paths

Repair all five P2 findings at 97915a: construct native byte axes through trusted class methods; revalidate profiles and derive identity through trusted serializers; expand capped LCP intervals before nonoverlapping selection; reject recipe-backed definitions not emitted by this cycle profile; and use trusted PrimePath replay for schedule derivation.

Nine new regression methods fail against the baseline and pass after repair. Full local suite: 152 passed, zero failures/errors/skips, source unchanged. Runtime/source/profile/native-lock digest: 18ac9197e0d081246a56a02c763e54b28e64ea05224be633976628c4cd22e5d3. Exact recovery and full-cost 6735-byte demo preserved. Uploaded blobs match tested bytes. Hosted checks and fresh terminal review remain separate gates.

UCNS sources, UCHC architecture reference, Stack ownership and cryptographic standing are unchanged.

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact repaired head 76508332f3535d5f5e60af69e8e1ca2afb9c50d9 against base d0e76d58f832a5664578af39103cdd0697c091d3. All five findings at 97915a have source-backed repairs in this commit:

  • 4191305892: _closed_definitions calls ByteOrigin.byte_axis(origin, ...) directly for both attachment and source axes. Native comparison and receipt/export paths also use trusted class methods.
  • 4191305894: Profile identity revalidates the complete profile/nested round fields and invokes Profile.as_dict / RoundSpec.as_dict directly, never supplied serializers.
  • 4191305897: capped LCP candidates expand to the full matching suffix interval before deterministic selection and deduplication. 00 01 00 01 00 01 01 now retains all three disjoint 00 01 occurrences. The declared profile is preserved, not replaced.
  • 4191305902: cycle inverse rejects recipe-backed definitions that its forward profile never emits. Standalone numeral prime recipes remain supported and tested.
  • 4191305906: scheduler route derivation invokes trusted PrimePath.replay, preserving primality/opcode/work-budget checks.

Nine regression methods were red on the old head and pass after repair, including explicit-prefix occurrence comparison across 1,022 short binary-alphabet byte strings. Full local source suite: 152 passed, zero failures/errors/skips; sources unchanged. Runtime/source/profile/native-lock SHA-256: 18ac9197e0d081246a56a02c763e54b28e64ea05224be633976628c4cd22e5d3. All eight published file blobs exactly match the locally tested/documented bytes.

The complete three-round demo still recovers exactly: 784 original bytes → 1,024 normalized → 910 → 1,669 → 6,632 payload + 103 framing = 6,735 total bytes. No cryptographic-strength or universal-compression claim. UCNS producer pins, UCHC architecture reference and Stack closure ownership are unchanged; native source lock now binds 5a49a4f43ab2baefbf5beda2e17cb3ba131c4b15.

Hosted full-checkout integration and this terminal review remain separate merge gates. Local Stack-consistency could not run fully from the inspection archive because that archive omits the vendored skill and EPAC release lock; the hosted full-checkout gate is required, not waived. No merge is claimed.

Copy link
Copy Markdown
Contributor Author

Verified hosted and bundle evidence at 7650833

Exact-head push run 37421506085, job 112131662014, passed all 152 tests, zero failures/errors/skips, source unchanged. Downloaded artifact 11392828990 has verified SHA-256 8c6dca1a719731adb67c5b009c08b8dc1cdd1a7212b42da2fd7a1a55a535ba81; its STACK_HEAD equals this exact head. Every changed source blob and runtime source/profile/native-lock digest matches the local repair.

The refreshed runnable bundle separately passed the same complete 152-test suite using only bundled sources and no package installation/network. Its digest matches the hosted receipt: 18ac9197e0d081246a56a02c763e54b28e64ea05224be633976628c4cd22e5d3. This is reproducibility of the same implementation, not an independent-author implementation or cryptographic review.

Hosted Stack-consistency run 37421510272 completed successfully from the full checkout, closing the local inspection-archive coverage gap. The PR-isolation Weave run 37421510323 also succeeded. The 6,735-byte full-cost demo still recovers exactly.

All five last-reported threads are repaired and resolved. Fresh review request is comment 6010374363, anchored to this head and base d0e76d58f832a5664578af39103cdd0697c091d3; terminal review and completion of every remaining integration check are still required before merge. No merge claimed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76508332f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/numeral.py Outdated
Comment thread research/weave/prime_schedule.py
Comment thread research/weave/native_binary.py Outdated
Repair all three P2 findings at 7650833: canonical Fraction fields before serialization/geometric work; complete Route replay and determinant validation before planning, with one scheduler engine through each cycle; trusted Geometry recovery, axis creation and coordinate replay.

Nine regression methods are red on the prior head and green after repair. Full local suite: 161 passed, zero failures/errors/skips, source unchanged. Runtime/source/profile/native-lock SHA-256 0724f421ff8404b0c7585113dd5ae498692a8dd5790b9e270073d0e0b5632ecc. The 6735-byte full-cost three-round demo still recovers exactly. All uploaded files match tested bytes. Hosted checks and fresh terminal review remain separate gates.

UCNS pins, UCHC architecture reference, Stack ownership and cryptographic standing are unchanged. Native source lock rotates; prior bound research records require regeneration.

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head 649e31284973de421f1d61a9be2fb8f17d742264 against base d0e76d58f832a5664578af39103cdd0697c091d3. All three P2 findings at 7650833 are repaired:

  • 4192099792: numeral attachments require exact integer numerator/denominator fields, a positive denominator, the admitted range and canonical normalization before wire encoding. Native coordinate/space validation uses the same canonical-field boundary; altered Fraction internals cannot emit records the decoder rejects.
  • 4192099805: plan invokes trusted Route.validate, replays the actual PrimePath and compares typed trace/determinant fields before selecting sections. Direct or mutated Route records cannot claim an unrelated determinant. Both cycle directions share the same scheduler work engine across initial evaluation and all validation replays; this fix does not reset the aggregate budget.
  • 4192099810: native recovery calls trusted Geometry.recover_axis and Geometry.lift; recovery's axis creation calls Geometry.axis. The cycle's geometric export paths also use the trusted class implementation. Instance overrides cannot license arbitrary source coordinates.

Nine new regression methods fail on the prior source and pass after repair. Full local suite: 161 passed, zero failures/errors/skips; source unchanged. Source/profile/native-lock SHA-256: 0724f421ff8404b0c7585113dd5ae498692a8dd5790b9e270073d0e0b5632ecc. Every uploaded file matches tested local bytes. New native binary blob: 6a6ba9f57b83b62116a57113a5c6358fab7e7831.

The three-round demo remains 784 source → 1,024 normalized → 910 → 1,669 → 6,632 payload + 103 framing = 6,735 bytes, exact recovery. UCNS source, UCHC architecture reference, Stack ownership and the construction's research-only cryptographic standing are unchanged. This validates supplied records; trusted Python runtime classes and producer modules remain trusted, not sandboxed.

Hosted exact-head/full-checkout integration and this fresh terminal review remain merge gates. No merge is claimed. Regression command: WEAVE_SOURCES=/checkouts python -m unittest discover -s tests -p test_terminal_records.py -v.

Copy link
Copy Markdown
Contributor Author

Exact-head evidence at 649e312

Push run 37423684120, job 112138447083, passed all 161 tests, zero failures/errors/skips. Artifact 11394415106 was downloaded; its SHA-256 is 91a3e05cd77dbfec12e3655424a8cd793806470b82d90cd53ce5c76729354f99. STACK_HEAD equals this revision. The eight changed files match the tested local bytes; every runtime/test/profile hash matches the local and standalone-bundle receipts.

All three executions agree on source/profile/native-lock SHA-256 0724f421ff8404b0c7585113dd5ae498692a8dd5790b9e270073d0e0b5632ecc and 161 passed. Standalone replay uses only bundled sources, without package installation or network. This is reproducibility of the same implementation, not an independent-author cipher review.

PR-isolation Weave run 37423689307 and full-checkout Stack-consistency 37423689361 are successful. The longer EPAC job 112138464123 and UCHC full-corpus integration job 112138464756 have also completed successfully; the other integration workflows were already green. The complete-cost demo still reconstructs exactly at 6,735 bytes.

All previously reported threads are resolved with source-backed repairs. Fresh terminal review is requested at comment 6010684679 for this head and base d0e76d58f832a5664578af39103cdd0697c091d3; no merge is claimed while that review remains incomplete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 649e312849

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/CYCLE.md Outdated
Comment thread research/weave/cycle.py Outdated
Repair final review findings at 649e312: parse complete bounded framing and match source/profile identities and round count before scheduler replay or native-source execution. Keep valid reverse operations and the existing aggregate scheduler budget unchanged.

Three regressions cover every truncated prefix, wrong magic, identity/count/length mismatch, noncanonical integers, trailing bytes, and valid-header budget enforcement. Invalid-header regressions fail on 649e312 and pass after repair. Full local suite: 164 passed, zero failures/errors/skips, source unchanged. Runtime/test/profile/native-lock SHA-256: 9f0b8812dc3b181ab0fe72780f7d0254bf2d9db7343f7fefdd7526715bfd8628. Demo remains 6735 complete bytes with exact recovery.

Update evidence inventory to 164 and explicitly mark 152 as a historical checkpoint. All four uploaded blobs match tested local bytes. No source-lock, wire format, profile, geometry, ownership or cryptographic-standing change. Hosted exact-head checks and terminal review remain separate gates.

Copy link
Copy Markdown
Contributor Author

@codex review

Please review current head 8bc5e1f7ce7f678fddde05e5b90c0aa42020f72c against base d0e76d58f832a5664578af39103cdd0697c091d3, including the two final findings from 649e312 and any remaining material issues in the declared construction. Their source-backed repair replies and regressions are in the preceding threads.

Delta: full cheap outer framing and identity checks now precede scheduler replay/native loading; three added header-admission regressions; current 164-test inventory and explicit historical labeling for 152. All 164 local tests passed with zero failures/errors/skips, unchanged source; 6,735-byte complete-cost demo still recovers exactly. All four remote blobs match local tested bytes. Runtime/test/profile/native-lock SHA-256: 9f0b8812dc3b181ab0fe72780f7d0254bf2d9db7343f7fefdd7526715bfd8628.

No native-source lock, UCNS producer, UCHC architecture reference, wire format, profile operation or cryptographic standing changed. This remains reversible construction research, not established encryption. Merge is conditional on current-head/base terminal review and all applicable checks.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8bc5e1f7ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/numeral.py Outdated
Separate trusted structural checks from recipe evaluation. Decoder-owned recipes each construct their block once under the shared engine; final packet validation checks all typed fields, attachments, uniqueness, occurrences and declared length without a second recipe replay. Public validation/export paths still replay supplied recipes, and no reusable validation flag or caller bypass is introduced.

Four regressions cover exact same-budget roundtrip, one replay per definition with aggregate refusal, malformed structure and mutation after decode. Update earlier budget tests to count actual necessary work and keep CLI operations under one shared allowance. The new roundtrip tests fail on 8bc5e1f and pass after repair.

Full local suite: 168 passed, zero failures/errors/skips; sources unchanged. Source/profile/native-lock SHA-256 c228c5c2a9b076757c5861ce275b21deff8fe73f30f9d6d561ff467e76187682. No native lock, wire format, profile formula, producer authority or cryptographic-standing change. Hosted checks and terminal review remain separate gates.

Copy link
Copy Markdown
Contributor Author

@codex review

Review head 07ac59976b9eb5c73974ea39c162670b676bf19c against unchanged base d0e76d58f832a5664578af39103cdd0697c091d3. The last P2 from 8bc5e1f is repaired with full regression evidence in its thread. Verify the single-replay decoder and remaining material issues in the declared construction; retain the scope boundary of trusted runtime classes and source-verified native producers, not a sandbox against arbitrary code replacing them.

The complete local suite passes 168 tests, zero failures/errors/skips. Exact-source digest: c228c5c2a9b076757c5861ce275b21deff8fe73f30f9d6d561ff467e76187682. All seven published files match the tested bytes. Decoder parsing already constructs every recipe value through one trusted replay; final typed structural validation reuses those values without a persistent validation flag or public bypass. Ordinary supplied-record validation/export still verifies recipes, and CLI operations retain one aggregate engine.

No profile, native-source lock, producer pin, wire format, ownership or security claim changes. Merge remains conditional on current-head/base terminal review and all applicable completed checks.

Copy link
Copy Markdown
Contributor Author

Observed exact-head validation at 07ac599

The exact branch-head push run 37450740470, job 112226423074, passed 168 tests, zero failures/errors/skips, with unchanged sources. Downloaded artifact 11405457972 has SHA-256 9f6c6d5d2c8cbb99bd8247fa0909c247c162010f962a23e065727edbe477be2a; its STACK_HEAD is this exact commit and its suite receipt reports source/profile/native-lock digest c228c5c2a9b076757c5861ce275b21deff8fe73f30f9d6d561ff467e76187682.

The hosted tracked source matches the local repair byte-for-byte. The refreshed standalone bundle was made from that hosted source and exact UCNS archive, then ran the complete 168-test suite successfully with the same digest and no package installation or network. This is source/replay evidence, not a second implementation or independent cryptographic verification.

The hosted demonstration also completed exact recovery at 6,735 total bytes for the 784-byte source, counting all definitions, positions, and framing. Wire format, native-source lock, profile formulas, ownership and cryptographic standing are unchanged.

The PR-isolation Weave run 37450748074 and Stack-consistency run 37450748251 passed. CodeQL 112226634907 reports no new alerts. Remaining integration/current-head review status is checked separately; this comment does not assert merge admission or completed review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07ac59976b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread research/weave/numeral.py Outdated
Comment thread research/weave/cycle.py
…ublic helpers

Repair the two P2 findings at 07ac599. Decode defers recipe evaluation until all definition metadata, complete recipe shapes, scope, uniqueness, references, length and framing have passed cheap validation. Accepted recipes still execute exactly once under the aggregate engine. No placeholder values, cached validation flag or caller bypass is introduced.

Normalize/denormalize invoke the trusted Profile validator; affix/unaffix close the same supplied-record boundary for RoundSpec before discovery or decoding. Valid formulas, native-source locks, producer pins, wire format and cryptographic standing remain unchanged.

Eight regression methods fail on 07ac599 (32 subtest failures, two errors) and pass after repair. Full local suite: 176 passed, zero failures/errors/skips, source unchanged. Source/profile/native-lock SHA-256: 607a9af7c0d749d5ab1233b260906a2dfa0d0c50c22abc4a186ed6142dc188b8. Six remote repair blobs match tested local files. Hosted exact-head tests and terminal review remain separate gates.

Copy link
Copy Markdown
Contributor Author

@codex review

Review current head cd6a1ffdf158e84c90d98bb36b609a633a0beb35 against unchanged base d0e76d58f832a5664578af39103cdd0697c091d3. Both P2 findings at07ac are repaired with source-backed replies and eight regression methods. The complete local suite passes 176 tests, zero failures/errors/skips. Source/profile/native-lock SHA-256: 607a9af7c0d749d5ab1233b260906a2dfa0d0c50c22abc4a186ed6142dc188b8.

Complete cheap numeral metadata/recipe shape/reference/framing checks now precede all prime evaluation. Accepted recipes still execute once per definition under one aggregate engine. Public normalize/denormalize and affix/unaffix validate their supplied Profile/RoundSpec via trusted class methods before field use. No fabricated values, persistent validation capability, public bypass, geometry/producer change or profile/wire alteration is introduced.

Please assess remaining material defects in the declared construction boundary. Runtime classes and source-verified producer modules are trusted; this is not an arbitrary-Python sandbox or an established encryption scheme. Merge is conditional on current-head/base terminal review and all applicable checks.

Copy link
Copy Markdown
Contributor Author

Verified exact-head source and recovery at cd6a1ff

Exact-head push run 37453594619, job 112235705676, passed 176 tests, zero failures/errors/skips, sources unchanged. Downloaded artifact 11407901860 has SHA-256 fceb373b139f5604a3602576bf94027c421bbc60574d392f13e5b5f7a9d2797b. Its HEAD matches this commit; all tracked source bytes match the local repair. Source/profile/native-lock digest: 607a9af7c0d749d5ab1233b260906a2dfa0d0c50c22abc4a186ed6142dc188b8.

The refreshed runnable bundle was reconstructed from the hosted tracked-source and UCNS archives and itself passed the complete 176-test suite with the same digest, no installation or network. This is exact-source reproducibility, not a second independent implementation. The hosted three-round demo recovered exactly at 6,735 complete bytes for its784-byte input, including definitions, coordinates and framing.

PR-isolation Weave run 37453599980 and Stack-consistency run 37453599929 passed. CodeQL 112235977977 completed with no new alerts. Review request 6014837855 still needs a terminal current-head/base result; this evidence comment does not assert merge admission. No native-source pin, wire format, profile formula, producer authority or cryptographic-standing change.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: cd6a1ffdf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@erinepshovel-code erinepshovel-code left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-revision repair verification

Head: cd6a1ffdf158e84c90d98bb36b609a633a0beb35
Base: d0e76d58f832a5664578af39103cdd0697c091d3

The reported repairs are present in this head: single-budget accounting and recipe replay; Stack-owned sequence closure with UCNS geometry; exact native record/scalar validation and trusted dispatch; deterministic discovery/profile enforcement during recovery. Later review refinements are preserved rather than overwritten.

Downloaded hosted artifact 11407901860 and verified SHA-256 fceb373b139f5604a3602576bf94027c421bbc60574d392f13e5b5f7a9d2797b, exact Stack/UCNS HEADs, and all 40 source hashes. Reran the complete suite from the extracted exact source under Python 3.13.5: 176 passed, 0 failures, 0 errors, 0 skips, source unchanged. Source/profile/native-lock digest: 607a9af7c0d749d5ab1233b260906a2dfa0d0c50c22abc4a186ed6142dc188b8. Reran the full demo: exact recovery, 6,735 complete bytes. This is reproducibility of the same implementation, not independent implementation or security evidence.

All eight observed PR-isolation workflows passed. Exact-head push evidence also passed; CodeQL completed with no new alerts. The Codex summary records terminal review on cd6a1ff at 2026-10-06T11:08:00Z, followed by the bot's +1 at 11:08:04Z. All listed review threads are resolved. No legacy status contexts are present. Main remains at the reviewed base; GitHub reports it unprotected and returns no repository/inherited rulesets. No protection or approval bypass is requested.

This comment records verification, not an APPROVED review or a merge result. Re-read head/base, mergeability and threads immediately before the expected-head guarded merge. Scope remains the reversible research cycle; private/public trapdoor construction and authentication remain unfinished.

@erinepshovel-code
erinepshovel-code merged commit ccf707f into main Oct 6, 2026
13 checks passed
erinepshovel-code added a commit that referenced this pull request Oct 6, 2026
Bring in weave #77 (ccf707f). Keep the skill-lib pin at 1b1a947; add weave's
ucns/uchc research participants; take main's updated weave boundary hmmm;
recompute work_graph_sha256 (6340a86d…). Drop the outdated AGENTS note that
the skill-lib snapshot refresh was still separate.
erinepshovel-code added a commit that referenced this pull request Oct 6, 2026
The merge kept the pre-#77 weave/stack research-participant relation, so
test_native_edges_and_forge_ownership_match_root_manifest failed looking for
"Stack-owned binary". Take main's weave participant records and recompute
work_graph_sha256 (7e2aeaee…).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant