Skip to content

fix(weave): byte-scoped whole-plus-one repair; proposed answers for approval - #76

Merged
erinepshovel-code merged 1 commit into
mainfrom
fix/weave-byte-whole-part
Oct 5, 2026
Merged

erinepshovel-code merged 1 commit into
mainfrom
fix/weave-byte-whole-part

Conversation

@erinepshovel-code

Copy link
Copy Markdown
Contributor

Authorized repair

Repairs the user's bit/byte and whole-circle corrections against base 92ccda0620c06bc46654939c061ceb2d36476cb9. Head: 04760570b86be8bf905ae384aa7600ed0ee6c3a1.

  • A message origin contains byte occurrences, not eight message axes per byte.
  • Each byte construction has eight source-bit placements, one per circle.
  • Every public key view is G0 plus exactly one of G1..G7; direct construction also enforces this.
  • Remove the per-bit sheet encoders and public-feedback recurrence from feat(weave): construct eight-to-two positional degeneration candidate #73/feat(weave): add message-origin axis coupling candidate #74 rather than extend them.
  • Correct the prior evidence scope: those implementations did not instantiate the requested architecture. Holding public sender inputs fixed cannot test private-key necessity by demanding a changed ciphertext.
  • Preserve the stated 16-bit-per-byte requirement as declared, NOT as an implemented serializer.
  • Q11-Q14 and carried-forward Q9 contain probable answers for user approval, all pending. No proposal becomes an executable default.

Honest capability boundary

This repair implements byte/placement records and the public pair shape. It does not implement native UCNS geometry, UCHC origin integration, dynamic positional encryption, KeyGen, cryptographic degeneration, or private decryption. Construction source recovery retains plaintext and is not decryption. The existing full-profile missing-operation refusal remains intact. No new substitute cipher is supplied.

File plan

Files Change/purpose Risk Required validation
research/weave/stages/eight_circle.py Replace wrong per-bit encoder with byte/star structure Wrong unit or leaked full key in public view All 256 bytes, all 40,320 assignments, seven views, invalid direct construction
research/weave/stages/message_origin.py Replace bit-axis recurrence with byte occurrence origin/attachment Repeated occurrences or message scopes collapse Exact binary recovery, distinct occurrences/scopes, malformed input
research/weave/tests/test_eight_circle.py, test_message_origin.py Replace tests of rejected substitutes with 22 regression methods Confusing structure tests with security Explicit nonclaims; removed APIs cannot return
research/weave/test.py Bind 74-method full inventory and correct receipt coverage Declared expansion reported as measured Exact-head full suite, no skips, source unchanged
research/weave/EIGHT_CIRCLE.md, QUESTIONS.md, SPECIFICATION.md Correct architecture/evidence, surface pending answers, remove stale deleted-verifier command Accidental ratification or stale substitute claims Review diff against user corrections and retained system layers

Local evidence

22 focused methods passed, zero failures/errors/skips. Includes all 256 byte values, 40,320 assignments and seven whole/part views. Focused local import used an isolated empty package initializer because the runtime cannot resolve github.com; full unchanged Stack/Weave integration is delegated to the existing hosted workflow, not claimed locally. No runtime/workflow changes conceal this environment boundary.

Expected full suite: 52 unchanged transport/assembly methods plus 22 repair methods = 74. Hosted checks and live review state must be read before merge. Changes are restricted to eight existing files under research/weave/; no libs, producer pins, authority transfer, new verifier, or deployment.

Usage

cd research/weave && python test.py --receipt /tmp/weave-check.json

Read research/weave/QUESTIONS.md for the next approval set. The repair may be merged independently of approving its explicitly pending research proposals.

hmmm: the actual forward/private-recovery positional construction remains unimplemented; approving a description is not evidence that it works.

…r-bit substitutes

Preserve message -> byte -> eight circle placements and require G0 in every public pair. Remove the PR 73/74 per-bit encoders and public feedback recurrence, correct the evidence scope and hidden-key perturbation premise, and surface Q11-Q14 plus Q9 for approval without enabling their proposed answers. Keep other Weave layers unchanged.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T08:51:00.577276Z 0476057 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

Exact-revision repair verification

Reviewed repair head 04760570b86be8bf905ae384aa7600ed0ee6c3a1 against base 92ccda0620c06bc46654939c061ceb2d36476cb9; tested merge candidate eb98aceeb58419268f7420b3bcb00946363f5e2d.

The hosted Weave run 37285821003, job 111684336032, checked that merge candidate and ran the complete 74-method suite: 74 passed, 0 failures, 0 errors, 0 skips, source unchanged. Code/profile receipt SHA-256: f905078fb7fd4a4a493ce7a60675c5490b66e1efe45e5bdff99b16e971f2b453. The receipt's repaired module/test digests match the locally tested source. Separate exact-head test check 111684136607 also completed successfully.

All seven current head checks are completed/success, including stack consistency, the three CodeQL language analyses, and the aggregate CodeQL check (now reports no new alerts, replacing its earlier transient missing-configuration warning). Codex review activity completed on this head at 2026-10-05T08:51:00Z; fresh reads show no inline review threads and no review submissions. This is not represented as an APPROVED review.

The inspected diff is restricted to eight existing Weave files. It removes the per-bit encoders and public-feedback substitute, restores byte-scoped placements and G0-plus-one public views, corrects the invalid evidence interpretation, and leaves all new question answers explicitly pending. No cipher, native geometry integration, private-key security, release, or deployment is claimed.

Merge admission remains conditional on the same head/base pair and mergeability at the final read. Merging this repair does not approve Q11-Q14 or Q9.

@erinepshovel-code
erinepshovel-code merged commit d0e76d5 into main Oct 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant