Repository navigation
Allow truthful unavailable model provenance in builder journals - #133
Merged
Merged
Conversation
erinepshovel-code
marked this pull request as ready for review
October 20, 2026 00:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Keep website-builder-journal as the authoritative contract: record the exact executing model when exposed, otherwise
model: unavailablewith a nonemptymodel_unavailable_reason. Separate optional requested/configured alias from actual response model. Preserve identity-dependent scientific/model-comparison evidence gates and append-only history.Update discovery summaries, contract regressions, the journal-only narrative preservation fixture, and deterministic generated adapter/native collection. No runtime, security, or deployment changes. skill-build and WDLL inspected; their doctrine needs no change.
Verification
Independent initial review: no remaining contract findings. 19 focused journal/WDLL/narrative tests pass. Native collection strict drift (CI Python 3.13), TypeScript, skill drift/compliance, adapter drift, ratios, llms drift, gonol authority, RepoLOTO audit and 7 checks pass.
Local full-suite comparison: 127 identical failures/errors on base and candidate, predominantly fail-closed Git visibility because the sandbox supplies an inaccessible synthetic /tmp/.git marker. Baseline also fails Python-version collection replay. Candidate initially had one stale journal-example preservation fixture; fixed and covered in the 19 passing focused tests. Initial CI collection drift from using default Python 3.12 was corrected by regenerating with CI's 3.13. Exact final-head CI remains required before merge.
Consumer
The-Interdependency.github.io consumes this contract in the coordinated Bastet transaction; its enforcement and public rendering are tested separately. Producer base: 83aef78. Consumer base: c955f2f9c36e69a68b8d3a7e0acb70e8fca6c36b. No semantic/scientific authority transfers through this publication relation.