Skip to content

Add typed S0-S6 multi-origin join terms - #10

Merged
erinepshovel-code merged 6 commits into
mainfrom
feat/multi-origin-join-term-v0
Sep 30, 2026
Merged

erinepshovel-code merged 6 commits into
mainfrom
feat/multi-origin-join-term-v0

Conversation

@erinepshovel-code

@erinepshovel-code erinepshovel-code commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Repair complete: green and review-clean

This repairs EPAC #10 against merged METAPAT #34. The earlier hold and old producer pin are superseded. Final review bound the exact head/base below: all five checks succeeded, all eight review threads were resolved, and GitHub reported the PR mergeable with a clean merge state. The guarded merge succeeded as a037aec400b5a1fce7e9eb7411b2ae4aa0c742aa, preserving the validated tree.

What changed

The producer requires stored state to remain distinct from scalar readouts and grants no Vector license to static bearing. Transformation and Time require result and occurrence evidence that this static constructor does not have.

Wire 0.2.0 therefore retains all seven origins, six authored relations, exact state, seating, holes, leftovers, provenance, equality, and public recovery while:

  • separating stored phase/capacity/facing properties from readouts that identify their origin, measured property, rule, and value;
  • retaining static bearing as sign readouts, with no Vector claim;
  • replacing the pre-merge JoinTransformation/transformations/transformation_id/sequence API with AuthoredJoin/joins/join_id/order, and claiming structural adjacency rather than Transformation or Time;
  • rejecting unreduced wire ratios, normalized payload changes, and noncanonical original JSON text (key order, whitespace, trailing newline, negative zero, and unnecessary Unicode escapes);
  • making the documented generator work without an installation and rejecting mismatched roots or loaded source before writing evidence.

The exact merged producer fixture is packaged byte-for-byte and checked against the consumer's role projection. Both work graphs, provenance, source/fixture hashes, and generated evidence are rebound. All 14 non-generated feature inputs are covered. No state-change or temporal evidence is fabricated.

Exact identities

  • Repaired EPAC head: 86f183157d663926df4ede7ce5d6e5f8f260d19f
  • EPAC tree: cbc3e4e89b4c9e8170c0db940f0862ae749c2ee6
  • EPAC base: 1e5c999286f12221eff9870d1372203ac7935f2a
  • Merged METAPAT producer: 1cdfb09dd00a451cee30eec2e78624df8c682662
  • Producer tree: d946a5a18b0c53fd561dcd9d68fdf36d5dd11638
  • Application: metapat.application.epac_join_terms@epac-join-terms-application-v4
  • Application digest: 461ef7e059aa65b514017683ba9b57058ee9f582bc63748fabd021cdeb660b4b
  • Candidate digest: 11504eb61c4952fc3da04a51d3779484194292db2c8a5c3174b3c3ea540e6442

Review evidence

All eight threads were reread against the repaired exact head. Each is addressed; none remains unresolved at this review.

Thread Repair / verification
PRRT_kwDOUPneN86nA-Z6 Direct generator subprocess with -S, no site packages, and an external working directory reports both artifacts CURRENT.
PRRT_kwDOUPneN86nBQEl Foreign checkout and mismatched loaded-module source are rejected before output writes; identical installed module bytes remain supported for artifact replay.
PRRT_kwDOUPneN86nY02M Original JSON text must equal the recovered tree's canonical serialization; all six alternate encoding regression cases fail while canonical UTF-8 round-trips.
PRRT_kwDOUPneN86nCgp6 Nonzero/zero phase and phase/occupancy readout ratios fail when unreduced, with both retained and recomputed digests.
PRRT_kwDOUPneN86nA-aD Digest-consistent duplicate leftover identity fails global origin/join/leftover uniqueness.
PRRT_kwDOUPneN86nA-aH The complete base-to-head feature diff matches all 14 manifest inputs, excluding only the two generated outputs.
PRRT_kwDOUPneN86nA-aM Source-only generator uses a file-location loader while the candidate stays imported from the installed artifact; all six final installed-artifact suites pass.
PRRT_kwDOUPneN86nA-aP Nested semantic mappings remain immutable; attempted mutation leaves existing candidate bytes unchanged.

Validation

Final exact-head CI run 36670392280 succeeded:

Runtime Installed wheel Installed source archive
Python 3.10 245 tests + 23 subtests passed 245 tests + 23 subtests passed
Python 3.11 245 tests + 23 subtests passed 245 tests + 23 subtests passed
Python 3.12 245 tests + 23 subtests passed 245 tests + 23 subtests passed
  • CodeQL and workflow analysis also succeeded.
  • Clean normalized wheel/sdist build and Twine passed with pinned CPython 3.11.15 and compile/runtime zlib 1.3.1.
  • Downloaded Python 3.11 CI evidence binds this exact head/tree, reports zero skips, and retains all 14 comparison standings as FALSIFIED. Both packaged artifacts are byte-identical to the local normalized build.
  • Direct/module generator drift checks, all 14 feature input hashes, producer commit/tree/application/source/fixture identities, and work-graph digest pass.
  • All 17 declared contracts, checks, and test functions reconcile.
  • Four original-head constructor variants preserve state, seating, numeric bearing/occupancy, provenance, adjacency, lineage, and bags.
  • All six noncanonical JSON encoding witnesses were accepted by predecessor 254804f and are rejected by final head 86f1831.
  • Every live thread was reread after the final matrix completed. There are no unresolved findings or change-requesting reviews.

Usage and explicit API migration: docs/multi-origin-join-term-v0.md. Run python tools/generate_join_term_v0.py --check and the repository's clean artifact replay workflow.

hmmm: this remains public representation research. Molecular-shape standing remains FALSIFIED. No Vector action, Transformation result, actual Time sequence, chemistry, physics, UCNS correspondence, energy coupling, secrecy, computational hardness, PCEA compatibility, production suitability, or release authority is established.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T04:50:40.068691Z 86f1831 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71a81baafb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/generate_join_term_v0.py
Comment thread epac_join_term.py
Comment thread tools/generate_join_term_v0.py
Comment thread tests/test_epac_join_term.py Outdated
Comment thread epac_join_term.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1807057cb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/generate_join_term_v0.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca9988d427

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread epac_join_term.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 254804f49d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread epac_join_term.py Outdated
@erinepshovel-code
erinepshovel-code merged commit a037aec into main Sep 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants