Repository navigation
docs(edcm): finish O/L canonical split cleanup - #81
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f87ed2841
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "marker_O_expand": +1.0, | ||
| "marker_O_contain": -1.0, |
There was a problem hiding this comment.
This renames the public A_MATRIX["metrics"]["O"] primitive schema, but the module still declares tests: hmmm, and no repository test references A_MATRIX or either new key. Consequently, the changed native module has no witness that its documentation-shaped matrix remains aligned with the frozen marker inventory or _compute_O; add a focused matrix/canon alignment test and declare it in MODULE_BUILD.
AGENTS.md reference: AGENTS.md:L65-L65
Useful? React with 👍 / 👎.
| Let $e_t$ and $c_t$ be hits from the frozen `scope_expansion` and | ||
| `scope_containment` marker categories: | ||
|
|
||
| $ |
There was a problem hiding this comment.
On GitHub, the lone $ starts inline math rather than the display-math form used for the other multiline equations in this reference, so this cases expression is rendered inline or exposed as malformed source instead of as the intended block. Restore $$ at both boundaries of the formula.
Useful? React with 👍 / 👎.
| "marker_O_expand": +1.0, | ||
| "marker_O_contain": -1.0, |
There was a problem hiding this comment.
When artifacts or consumers select this exported matrix schema by MATRIX_VERSION, they cannot distinguish the old marker_O_over/marker_O_under fields from these new names because both shapes still advertise version 1.0; even freeze(A_MATRIX) now produces a different identity for that same version. Bump the matrix version or retain the version-1 key shape so version-based readers do not request the wrong primitive fields.
Useful? React with 👍 / 👎.
1 participant
Completes the canonical O/L identity repair already merged in #79/#80. Removes stale O/L naming-conflict language from the domain claim, updates the mathematical reference so legacy O is explicitly O_scope and legacy L is L_loss, and aligns the documentation-shaped A matrix with the actual frozen scope-expansion/scope-containment marker inventory. No scalar formula, vector arity, frozen marker bytes, or sibling canonical axis is collapsed.