Repository navigation
fix(public): establish a safe a0p release boundary - #109
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cfe3dee8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address that feedback Repair the currently active P1/P2 review findings on the exact current PR branch, and only those findings. In particular: gate the effective persisted orchestration mode/provider list before execution; preserve |
|
To use Codex here, create an environment for this repo. |
|
@codex address that feedback Repair the live exact-review findings on the current public-readiness branch, prioritizing the three P1s before P2s. P1 scope: gate the same effective persisted orchestration mode/provider list that execution receives; bind/reset |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b04abfad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex Address the current live exact-head review findings only; keep this PR unreleased and unmerged until every P1/P2 is repaired and re-reviewed. Prioritize P1s: gate the same persisted orchestration mode/providers execution uses; preserve current_user_tier across both approval replay paths; derive production client IP correctly across the declared Cloud Run proxy chain; and supply a source-backed admin bootstrap/promotion path instead of deploying ADMIN_EMAIL without the credential seedAdminUser requires. Then repair the live P2s without widening scope: attachment-only chat validation; Google Fonts CSP or remove/self-host those origins; atomic guest reservation settlement/release; bounded retention for rate_* probes; enforce actual orchestration call count rather than provider lanes; bind tier for CLI/Fleet tool-enabled inference; preserve admin discovery of system built-in tools. Add focused regressions for each repaired boundary, re-run the existing full Python/TypeScript/container/public-policy gates plus fresh CodeQL, and request exact-head review. Do not weaken public security/cost/privacy boundaries to make tests green. Preserve launch-only history purge, staging, Secret Manager, durable attachments, and memory/privacy gates as hmmm/release work rather than folding them into this repair. |
|
@codex address that feedback Use the bounded repair scope in my immediately preceding comment. Repair every currently live P1/P2 thread on the current PR branch, add focused regressions, and keep release-only hmmm outside this code repair. |
|
To use Codex here, create an environment for this repo. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b04abfad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address that feedback Repair the live P1 boundary defects on current head before any P2 cleanup or merge attempt. In particular: (1) gate the effective persisted orchestration mode/provider list actually executed; (2) preserve resolved account tier across approved tool replays and every tool-enabled entry point; (3) derive/normalize production client identity across Cloud Run proxy hops and encoded paths so paid-inference rate limits cannot be bypassed; (4) provision a documented fresh-deployment admin bootstrap path without manual DB edits; (5) replace suffix-only |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b04abfad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Repair current authorization, provider routing, orchestration budgeting, request metering, guest accounting, bootstrap, and discovery findings. Add executable regressions and restrict workflow token permissions. Preserve PUBLIC_RELEASE deployment-only gates and honest hmmm.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| db.tier = "ws" | ||
| monkeypatch.setattr(domain, "check_scope_grant_tier", AsyncMock()) | ||
| monkeypatch.setattr(policy_loader, "get_scope_categories", lambda: {"publish": {"label": "Publish", "description": "publication"}}) | ||
| monkeypatch.setattr(policy_loader, "get_safety_floor_actions", lambda: set()) |
Keep CLI metering IP-backed without handling bearer secrets in Express. Use exact CSP-origin assertions and configure the mocked provider test job. Preserve every launch gate; no CodeQL alert waivers.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35ee3b19d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Exact-head closeout at |
2 participants
Outcome
Public-release candidate for a0p. The current repair head is
35ee3b19d838b7e4ebd23380ec74a6e5933993f6; merge and public deployment remain separate decisions.Live review repairs
The audit reproduced all 16 open P1/P2 findings at
4b04abfad44df2a6f982559b57f1732ae8e78cccand repaired their owning code paths:WS_USER_IDS. Remove unverified-email authority from admin guards as the same privilege-escalation boundary. Stored historical tiers still require operator review before launch.ADMIN_PASSWORDthrough Secret Manager, seed both admin role and tier, and fail closed on an existing unverified account claiming the bootstrap email.The current CodeQL alert was localized from its check-run annotation to missing workflow token permissions in
.github/workflows/deploy.yml, not the already-resolved Helmet CSP finding. The repair sets workflow-defaultcontents: read. The final exact-head CodeQL check is successful with zero annotations, and every language/actions analysis completed successfully. No alerts were waived or dismissed.PUBLIC_RELEASE.mdmaps every finding to its repair and regression witness. Changes are limited to existing authorization/routing/rate/storage/bootstrap code, deployment configuration, regression tests, and usage/release documentation. No runtime data, credentials, cloud resources, or Git history were altered.Verification at repair head
env -u REPL_ID NODE_ENV=production node --import tsx script/build.ts(the workspace blocks the tsx CLI IPC socket).9a58c3fc9526735fdf9a596f19810c5198565ddc.Merge decision
Ready for re-review; not yet cleared to merge. Code, build, database, and CodeQL gates pass, but the previously requested exact-head re-review has not been completed. No merge or deployment was performed.
Public launch remains blocked
Preserve
PUBLIC_RELEASE.md: historical runtime-data purge and credential review/rotation; verified historical WS account ownership; configured Cloud Run/PostgreSQL/Secret Manager and deployment opt-in; staging registration/session/guest/chat/provider/ownership/proxy tests; current-head zero-new-alert CodeQL; durable shared attachments or continued disablement; privacy/consent/audit gates before exposing system-primary or cross-owner features; then hostname/TLS/webhook and rollback evidence.hmmm: do not treat source repairs, historical green checks, or a hostname as a merge approval or live deployment. CI/CodeQL are verified at the exact repair head; reviewer confirmation and the separate public-launch prerequisites remain unresolved.