Skip to content

Conversation

@MiguelG97
Copy link
Member

Description

Fixes #679

The IfcLoader component currently does not expose the options to load all relations and attributes. As a result, users cannot enable full IFC data loading through the IfcLoader wrapper. The only available way is to use the standalone IfcImporter class, which bypasses the fragment manager and therefore misses out on built-in features like measurement, raycast, and other components.

serializer.addAllRelations();
serializer.addAllAttributes();

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

node-app
node-app

.DS_Store
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps macOS devs avoid accidentally pushing this system file

@HoyosJuan
Copy link
Member

Hey @MiguelG97! Hope you are fine.

Thanks for your PR. Currently, the IfcLoader exposes the FRAGS.IfcImporter in the method configuration.

instanceCallback?: (importer: FRAGS.IfcImporter) => void;

It can be used to update the classes object and include all the IFC Classes you need.

Would that solve the situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With different ifc file format not getting all properties

2 participants